remove double slashes in grunion module file paths#5993
Closed
diggy wants to merge 1 commit intoAutomattic:masterfrom
diggy:patch-1
Closed
remove double slashes in grunion module file paths#5993diggy wants to merge 1 commit intoAutomattic:masterfrom diggy:patch-1
diggy wants to merge 1 commit intoAutomattic:masterfrom
diggy:patch-1
Conversation
plugin_dir_path() uses trailingslashit()
Contributor
|
Thanks for the patch, this LGTM and will make it into the march release (scheduled first week of March) |
jeherve
requested changes
Feb 3, 2017
Member
jeherve
left a comment
There was a problem hiding this comment.
This looks good, thanks for the patch! Do you think you could fix another instance where this is an issue at the same time?
Thanks!
diff --git a/modules/contact-form/admin.php b/modules/contact-form/admin.php
index e0ef1db..c03740b 100644
--- a/modules/contact-form/admin.php
+++ b/modules/contact-form/admin.php
@@ -775,7 +775,7 @@ add_action( 'omnisearch_add_providers', 'grunion_omnisearch_add_providers' );
function grunion_omnisearch_add_providers() {
// Feedback uses capability_type 'page'
if ( current_user_can( 'edit_pages' ) ) {
- require_once( GRUNION_PLUGIN_DIR . '/grunion-omnisearch.php' );
+ require_once GRUNION_PLUGIN_DIR . 'grunion-omnisearch.php';
new Jetpack_Omnisearch_Grunion;
}
}
Contributor
|
This is being replaced by #6384 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
plugin_dir_path()usestrailingslashit()