Skip to content

Stats: minor naming change for widgets views#5478

Closed
lancewillett wants to merge 1 commit intomasterfrom
fix/widget-stats-name
Closed

Stats: minor naming change for widgets views#5478
lancewillett wants to merge 1 commit intomasterfrom
fix/widget-stats-name

Conversation

@lancewillett
Copy link
Copy Markdown
Contributor

@lancewillett lancewillett commented Nov 1, 2016

Janitorial naming fix, minor.

The stat name changed on the WP.com side, and this reflects that — it's more specific.

@lancewillett lancewillett added Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Stats Data Feature that enables users to track their site's traffic and gain insights on popular content. labels Nov 1, 2016
@lancewillett lancewillett added this to the 4.4 milestone Nov 1, 2016
@jeherve jeherve added [Type] Janitorial [Status] Needs Review This PR is ready for review. [Status] Tested on WP.com and removed Enhancement Changes to an existing feature — removing, adding, or changing parts of it labels Nov 2, 2016
@jeherve
Copy link
Copy Markdown
Member

jeherve commented Nov 2, 2016

We have another instance of jetpack_bump_stats_extras in modules/widgets/social-media-icons.php.

Would it be worth consolidating the 2 actions (jetpack_bump_stats_extras and jetpack_stats_extra) into a single one, and add that action to all widgets? It's currently missing from a few of them.

@jeherve jeherve added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Nov 2, 2016
@lancewillett
Copy link
Copy Markdown
Contributor Author

lancewillett commented Nov 2, 2016

Thanks for the catch, I'll updated the pull request with the other case.

Would it be worth consolidating the 2 actions

No, let's keep them separate — one is for pageviews, the other is for specific actions.

add that action to all widgets

If there are some missing, let's open a PR to get them added.

@lancewillett
Copy link
Copy Markdown
Contributor Author

lancewillett commented Nov 2, 2016

We have another instance of jetpack_bump_stats_extras in modules/widgets/social-media-icons.php.

Actually, that's unrelated. We can ignore that one. Just changing anything that was named widget to widget_view.

@lancewillett lancewillett added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Nov 2, 2016
@lancewillett
Copy link
Copy Markdown
Contributor Author

lancewillett commented Nov 2, 2016

I'll probably just make a new PR to encompass adding new stats with renaming existing ones.

@lancewillett lancewillett mentioned this pull request Nov 2, 2016
Merged
@lancewillett
Copy link
Copy Markdown
Contributor Author

lancewillett commented Nov 2, 2016

Closing in favor of #5488

@lancewillett lancewillett deleted the fix/widget-stats-name branch November 2, 2016 16:01
@jeherve jeherve removed the [Status] Ready to Merge Go ahead, you can push that green button! label Nov 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

[Feature] Stats Data Feature that enables users to track their site's traffic and gain insights on popular content. [Status] Tested on WP.com Touches WP.com Files [Type] Janitorial

Projects

None yet

Milestone

4.4

Development

Successfully merging this pull request may close these issues.

3 participants

@lancewillett @jeherve @matticbot