Forms: Add item click handler for DataViews on dashboards by dhasilva · Pull Request #46752 · Automattic/jetpack

dhasilva · 2026-01-23T23:25:26Z

Proposed changes:

Uses the onClickItem prop to handle item selection, given that the current click behavior was removed on DataViews 11.2
This does not match exactly the current implementation, and that is deliberate to better match the UI. Clicking on an item will always set this item as the only selected item.

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

To see this after the change in DataViews, checkout #46430 and apply this PR's changes on top of it, but this is optional.

Go to the responses dashboard
Click on an item's "From" text
Check that the item is selected
Also check the wp-build dashboard for the same behavior

This does not apply for the forms dashboard, as there is no "View" action there at this point.

github-actions · 2026-01-23T23:26:27Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the update/forms-click-item branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack update/forms-click-item

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2026-01-23T23:26:40Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Copilot

Pull request overview

This PR adds onClickItem handlers to the Forms dashboards to restore item selection functionality that was removed in DataViews 11.2.0. The handlers ensure clicking on an item in the responses or inbox dashboards selects that item exclusively.

Changes:

Added onClickItem callback to both inbox and responses dashboards that sets the clicked item as the only selected item
Updated TypeScript casting in the responses stage component

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
projects/packages/forms/src/dashboard/inbox/stage/index.js	Adds onClickItem handler to select items when clicked in inbox dashboard
projects/packages/forms/routes/responses/stage.tsx	Adds onClickItem handler for responses dashboard and updates type casting
projects/packages/forms/changelog/update-forms-click-item	Changelog entry for the new feature

Copilot · 2026-01-23T23:29:18Z

projects/packages/forms/changelog/update-forms-click-item

+Significance: patch
+Type: added
+
+Forms: Add item click handler for DataViews on dashboards


The changelog entry should end with a period according to the project's changelog guidelines. The entry should read: "Add item click handler for DataViews on dashboards."

Copilot · 2026-01-23T23:29:18Z

projects/packages/forms/src/dashboard/inbox/stage/index.js

+	const onClickItem = useCallback(
+		item => {
+			onChangeSelection( [ item.id.toString() ] );
+		},
+		[ onChangeSelection ]
+	);


The onClickItem callback is missing analytics tracking that exists in the desktopViewAction (lines 522-525). Since this new handler serves a similar purpose of selecting an item for viewing, consider adding analytics tracking using jetpackAnalytics.tracks.recordEvent to maintain consistency with the existing 'view-response' action tracking. This would help maintain visibility into how users interact with items in the dashboard.

Copilot · 2026-01-23T23:29:18Z

projects/packages/forms/routes/responses/stage.tsx

 	const navigate = useNavigate();
 	const counts = useSelect(
-		select => ( select( dashboardStore ) as SelectActions ).getCounts(),
+		select => ( select( dashboardStore ) as unknown as SelectActions ).getCounts(),


This casting change from as SelectActions to as unknown as SelectActions appears unrelated to the PR's stated purpose of adding an item click handler for DataViews. If this change addresses a TypeScript error, it should be explained in the PR description or handled in a separate commit. If it's unrelated to the DataViews 11.2 update, consider removing it from this PR to maintain focus on the primary change.

Suggested change

select => ( select( dashboardStore ) as unknown as SelectActions ).getCounts(),

select => ( select( dashboardStore ) as SelectActions ).getCounts(),

jp-launch-control · 2026-01-23T23:36:49Z

Code Coverage Summary

Coverage changed in 1 file.

File	Coverage	Δ%	Δ Uncovered
projects/packages/forms/src/dashboard/inbox/stage/index.js	0/180 (0.00%)	0.00%	2 ❤️‍🩹

Full summary · PHP report · JS report

simison · 2026-01-26T09:41:34Z

I also removed the special underline styling on mobile, which was diverging from DataViews styles:

Before

After

(three dots bug will be fixed with DataViews update)

simison

Tests well; tested WP admin and CIAB admin versions, as well as mobile version.

dhasilva requested a review from a team January 23, 2026 23:25

dhasilva self-assigned this Jan 23, 2026

Copilot AI review requested due to automatic review settings January 23, 2026 23:25

dhasilva added [Status] Needs Review This PR is ready for review. Task labels Jan 23, 2026

Copilot started reviewing on behalf of dhasilva January 23, 2026 23:25 View session

github-actions bot added [Feature] Forms [Package] Forms labels Jan 23, 2026

Copilot AI reviewed Jan 23, 2026

View reviewed changes

dhasilva and others added 3 commits January 26, 2026 11:33

add onClickItem handlers for dashboard DataViews

16bd4bf

changelog

3b78dcf

Remove special styling on mobile

eea6732

simison force-pushed the update/forms-click-item branch from 3a80b2b to eea6732 Compare January 26, 2026 09:38

simison approved these changes Jan 26, 2026

View reviewed changes

simison merged commit bb8e315 into trunk Jan 26, 2026
70 checks passed

simison deleted the update/forms-click-item branch January 26, 2026 09:53

github-actions bot removed the [Status] Needs Review This PR is ready for review. label Jan 26, 2026

simison mentioned this pull request Jan 26, 2026

Update dependency @wordpress/dataviews to v11.2.0 #46430

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Forms: Add item click handler for DataViews on dashboards#46752

Forms: Add item click handler for DataViews on dashboards#46752
simison merged 3 commits intotrunkfrom
update/forms-click-item

dhasilva commented Jan 23, 2026

Uh oh!

github-actions bot commented Jan 23, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 23, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 23, 2026

Uh oh!

Copilot AI Jan 23, 2026

Uh oh!

Copilot AI Jan 23, 2026

Uh oh!

jp-launch-control bot commented Jan 23, 2026 •

edited

Loading

Uh oh!

simison commented Jan 26, 2026 •

edited

Loading

Uh oh!

simison left a comment •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	select => ( select( dashboardStore ) as unknown as SelectActions ).getCounts(),
	select => ( select( dashboardStore ) as SelectActions ).getCounts(),

Conversation

dhasilva commented Jan 23, 2026

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Uh oh!

github-actions bot commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

Uh oh!

jp-launch-control bot commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

simison commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

simison left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Jan 23, 2026 •

edited

Loading

jp-launch-control bot commented Jan 23, 2026 •

edited

Loading

simison commented Jan 26, 2026 •

edited

Loading

simison left a comment •

edited

Loading