CRM: PHP notices: Translation loading for the zero-bs-crm domain was triggered too early. #3542 by mikestottuk · Pull Request #44109 · Automattic/jetpack

mikestottuk · 2025-06-26T17:48:11Z

Fixes Automattic/zero-bs-crm#3542

Proposed changes:

Removed the plugins_loaded hook registration that was calling load_textdomain() from the init_hooks() method in ZeroBSCRM.Core.php
This prevents the text domain from being loaded too early in the WordPress initialization sequence
Fixes the PHP notice: "Function _load_textdomain_just_in_time was called incorrectly. Translation loading for the zero-bs-crm domain was triggered too early."

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Enable WP_DEBUG and WP_DEBUG_LOG in wp-config.php
Activate the plugin
Check debug.log for any "translation loaded too early" notices
Verify that all translations still work correctly in the admin area
Test with different languages to ensure translations are loading properly
Verify that no other functionality is affected by this change

github-actions · 2025-06-26T17:49:10Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

jp-launch-control · 2025-06-27T13:34:01Z

Code Coverage Summary

Coverage changed in 3 files.

File	Coverage	Δ%	Δ Uncovered
projects/plugins/crm/ZeroBSCRM.php	0/171 (0.00%)	0.00%	35 💔
projects/plugins/crm/includes/ZeroBSCRM.Database.php	0/276 (0.00%)	0.00%	2 ❤️‍🩹
projects/plugins/crm/includes/ZeroBSCRM.Core.php	0/973 (0.00%)	0.00%	-7 💚

Full summary · PHP report

_{Coverage check overridden by

I don't care about code coverage for this PR
Use this label to ignore the check for insufficient code coveage.
.}

tbradsha · 2025-07-01T18:52:08Z

projects/plugins/crm/ZeroBSCRM.php

-	$zbs = ZeroBSCRM::instance();
+	// init hook
+	add_action(
+		'init',


I'll note that we're changing the load order here; I'm not sure what implications this might have for extensions that register with CRM (e.g. Mail Campaigns or WooSync).

On the plus side, this sets the stage to clean up several lines in ZeroBSCRM::init_hooks() to no longer use the init hook.

tbradsha · 2025-07-01T18:54:01Z

projects/plugins/crm/includes/ZeroBSCRM.Core.php

 		do_action( 'before_zerobscrm_init' );

-		// After all the plugins have loaded (THESE FIRE BEFORE INIT)
-		add_action( 'plugins_loaded', array( $this, 'load_textdomain' ) ); // } Translations


Should we chop ZeroBSCRM::load_textdomain now?

tbradsha · 2025-07-01T19:02:30Z

projects/plugins/crm/includes/ZeroBSCRM.Database.php

-		return $zbs->database_server_info['db_engine_label'];
+
+	// If $zbs is an object but database_server_info is not set, try to populate it.
+	if ( is_object( $zbs ) && ! isset( $zbs->database_server_info ) ) {


Did you run into an issue with this? If $zbs is not an object, we should probably return early.

Related, $zbs->database_server_info will always be set if $zbs is an object, given that it's initialized as an empty object. It's also populated as early as possible (within $zbs->verify_minimum_requirements()).

In other words, if $zbs is an object, the rest of the checks are unnecessary and the fallback scenario isn't possible.

tbradsha · 2025-07-01T19:04:45Z

projects/plugins/crm/tests/codeception/acceptance/11_JPCRM_Activation_Cest.php


-		// Activating the plugin directly loads the welcome wizard, so no need to move pages here.
+		// Click the activate link for jetpack-crm directly
+		$I->click( 'Activate', array( 'css' => 'tr[data-slug="jetpack-crm"] .activate a' ) );


I presume this is because the $I->activatePlugin() uses the bulk activation route? This might be irrelevant now that I've adjusted it to support bulk activation with one plugin.

tbradsha · 2025-07-01T19:05:29Z

projects/plugins/crm/tests/php/bootstrap.php

 	global $zbs;
-	$zbs->install();
-	zeroBSCRM_notifyme_createDBtable();
+	if ( class_exists( 'zeroBSCRM' ) && ! isset( $zbs ) ) {


Why do we need this check? We literally load the class file and we know it's not set. :^)

tbradsha · 2025-07-01T19:09:08Z

projects/plugins/crm/tests/php/bootstrap.php

+	// Run installation if needed
+	if ( isset( $zbs ) && is_object( $zbs ) && method_exists( $zbs, 'install' ) ) {
+		$zbs->install();
+		if ( function_exists( 'zeroBSCRM_notifyme_createDBtable' ) ) {


Same thing here...if $zbs is instantiated, that means it's run the __construct(), which means it's run $zbs->includes(), which means this function does exist. There's no way to get to this point and not have the function exist.

tbradsha · 2025-07-01T19:09:40Z

projects/plugins/crm/tests/php/bootstrap.php

+	}
+
+	// Run installation if needed
+	if ( isset( $zbs ) && is_object( $zbs ) && method_exists( $zbs, 'install' ) ) {


This is overkill and not needed. :^)

unless someone deletes the install function?

tbradsha

Some comments to consider...

tbradsha · 2025-07-01T19:19:06Z

projects/plugins/crm/tests/codeception/acceptance/11_JPCRM_Activation_Cest.php

+		$this->assertWizardIsShown( $I );
+	}
+
+	public function test_bulk_plugin_activation_skips_wizard( AcceptanceTester $I ) {


I suspect this doesn't show the wizard because technically the option already is set. So more accurately this is testing if the wizard shows on second load.

This won't fire regardless since the `jpcrm_wizard_completed` option is already set at this point. Also, we now only skip the wizard if more than one plugin is activated via this method.

tbradsha · 2025-07-03T14:44:13Z

projects/plugins/crm/includes/ZeroBSCRM.Core.php

 	public function frontend_includes() {
 	}

-	/**


tbradsha · 2025-07-03T14:59:36Z

projects/plugins/crm/tests/codeception/acceptance/11_JPCRM_Activation_Cest.php

+		$this->assertWizardIsShown( $I );
+	}
+
+	public function test_bulk_plugin_activation_skips_wizard( AcceptanceTester $I ) {


mikestottuk added 3 commits June 26, 2025 18:34

new activation redirect and translation loading

ade95bb

Changelog

c8d7dd1

removing translation loading from class

0ef7d7f

github-actions bot added the [Plugin] CRM Issues about the Jetpack CRM plugin label Jun 26, 2025

github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Jun 26, 2025

mikestottuk added 2 commits June 26, 2025 18:49

removing translation loading from class

c8d7f47

reapply core changes

1040830

mikestottuk requested a review from tbradsha June 26, 2025 17:58

fix the bootstrap test

1d7a0b2

github-actions bot added the [Tests] Includes Tests label Jun 27, 2025

manually defining the test again

d71a89d

mikestottuk added 3 commits June 27, 2025 14:52

show wizard if activating mulitple plugins - for unit test testing

71d1b1b

wizard and tests

3d37441

improving activation tests

81e5f0d

mikestottuk force-pushed the fix/crm/clean-translation-loading branch from 0f11714 to 81e5f0d Compare June 27, 2025 15:53

mikestottuk added 7 commits June 27, 2025 17:02

firming up tests

3d24381

change test to allow for redirection

be9024c

more tests

0b99325

fixing the bulk activation test for wizard not shown

3c6ed00

fixing plugin name in activation test

6a6b1fa

fixing plugin name in activation test

3eef2bb

making it so the jpcrm_database_engine does not rely on

1d40349

tbradsha added 2 commits July 1, 2025 12:38

Skip feedback on bulk deactivation

29957cf

Reshuffle activation redirect logic

e77bf99

tbradsha reviewed Jul 1, 2025

View reviewed changes

tbradsha and others added 8 commits July 1, 2025 13:21

Merge branch 'trunk' into fix/crm/clean-translation-loading

b38a8c0

some tidy

5bb6f99

more tidy

137fc54

tidy acceptance

c095c1d

tidy acceptance with jetpack-crm slug

f8a2bd8

Remove unneeded check

c44fbec

Merge branch 'trunk' into fix/crm/clean-translation-loading

43d303f

Chop bulk activation wizard skip test

d2e27d5

This won't fire regardless since the `jpcrm_wizard_completed` option is already set at this point. Also, we now only skip the wizard if more than one plugin is activated via this method.

tbradsha previously approved these changes Jul 3, 2025

View reviewed changes

tbradsha dismissed their stale review via 24dbd9f July 3, 2025 16:11

tbradsha force-pushed the fix/crm/clean-translation-loading branch from 24dbd9f to d2e27d5 Compare July 3, 2025 16:24

tbradsha added 2 commits July 3, 2025 10:39

Another try

de7950d

Fine, let's go with this

9c32884

tbradsha approved these changes Jul 3, 2025

View reviewed changes

tbradsha merged commit 7b9e31f into trunk Jul 3, 2025
64 checks passed

tbradsha deleted the fix/crm/clean-translation-loading branch July 3, 2025 17:07

github-actions bot removed the [Status] Needs Review This PR is ready for review. label Jul 3, 2025

This was referenced Jul 8, 2025

CRM: Fix daterangepicker regression in dash #44236

Merged

CRM: Resolves #44256 - Fix regression that caused excess queries #44259

Closed

Conversation

mikestottuk commented Jun 26, 2025 • edited by tbradsha Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Uh oh!

github-actions bot commented Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jp-launch-control bot commented Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tbradsha left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mikestottuk commented Jun 26, 2025 •

edited by tbradsha

Loading

github-actions bot commented Jun 26, 2025 •

edited

Loading

jp-launch-control bot commented Jun 27, 2025 •

edited

Loading