Skip to content

Cornestone pages: avoid fatals on module activation#43171

Merged
jeherve merged 1 commit intotrunkfrom
fix/cornerstone-no-pages
Apr 22, 2025
Merged

Cornestone pages: avoid fatals on module activation#43171
jeherve merged 1 commit intotrunkfrom
fix/cornerstone-no-pages

Conversation

@jeherve
Copy link
Copy Markdown
Member

@jeherve jeherve commented Apr 21, 2025

Fixes HOG-77

Proposed changes:

Avoid issues like this one:

PHP Fatal error:  Uncaught TypeError: array_map(): Argument #2 ($array) must be of type array, null given in /usr/local/src/jetpack-monorepo/projects/plugins/boost/app/lib/cornerstone/class-cornerstone-utils.php:21
Stack trace:
  thrown in /usr/local/src/jetpack-monorepo/projects/plugins/boost/app/lib/cornerstone/class-cornerstone-utils.php on line 21

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

  • N/A

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

@jeherve
Cornestone pages: avoid fatals on module activation
5d75b37 
Fixes HOG-77

```
PHP Fatal error:  Uncaught TypeError: array_map(): Argument #2 ($array) must be of type array, null given in /usr/local/src/jetpack-monorepo/projects/plugins/boost/app/lib/cornerstone/class-cornerstone-utils.php:21
Stack trace:
  thrown in /usr/local/src/jetpack-monorepo/projects/plugins/boost/app/lib/cornerstone/class-cornerstone-utils.php on line 21
```
@jeherve jeherve added Bug When a feature is broken and / or not performing as intended [Status] Needs Review This PR is ready for review. [Boost Feature] Lcp labels Apr 21, 2025
@jeherve jeherve requested a review from a team April 21, 2025 16:38
@jeherve jeherve self-assigned this Apr 21, 2025
@github-actions github-actions bot added the [Plugin] Boost A feature to speed up the site and improve performance. label Apr 21, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 21, 2025 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Boost plugin:

  • Next scheduled release: April 30, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@jp-launch-control
Copy link
Copy Markdown

jp-launch-control bot commented Apr 21, 2025

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/plugins/boost/app/lib/cornerstone/class-cornerstone-utils.php 0/14 (0.00%) 0.00% 2 ❤️‍🩹

Full summary · PHP report · JS report

@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Apr 21, 2025
@jeherve jeherve merged commit 589d927 into trunk Apr 22, 2025
73 of 74 checks passed
@jeherve jeherve deleted the fix/cornerstone-no-pages branch April 22, 2025 10:12
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Apr 22, 2025
@github-actions github-actions bot added this to the boost/3.14.0 milestone Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kraftbj kraftbj kraftbj approved these changes

Assignees

@jeherve jeherve

Labels

[Boost Feature] Lcp Bug When a feature is broken and / or not performing as intended [Plugin] Boost A feature to speed up the site and improve performance.

Projects

None yet

Milestone

boost/4.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@jeherve @kraftbj