refactor: Register jetpack-connection scripts absolutely#42468
Merged
refactor: Register jetpack-connection scripts absolutely#42468
Conversation
Contributor
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Contributor
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
e83a397 to
6634899
Compare
sergeymitr
approved these changes
Mar 20, 2025
Contributor
sergeymitr
left a comment
There was a problem hiding this comment.
Works well, thanks for taking care of that.
Reverts: - #39604 - #39870 Conditional registration was added to address *perceived* performance issues, rather than *actual* performance issues. While enqueueing assets comes at a network cost, registration should not, in theory, incur such cost. Registration is light-weight operation. Conditionally registered assets are problematic as they are difficult to query globally. If an asset is conditionally registered within a specific context, it will be unavailable outside of that context. E.g., a REST API endpoint is unable to query an asset conditionally registered with WP Admin.
6634899 to
78cbdb6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Revert #39604.
Conditional registration was added to address perceived performance
issues, rather than actual performance issues. The changes were made
to reduce the total number of Jetpack hooks and associated functions.
While unnecessarily enqueueing assets comes at a network cost,
registration should not, in theory, incur such a cost. Registration is a
light-weight operation.
Conditionally registered assets are problematic as they are difficult to
query globally. If an asset is conditionally registered within a
specific context, it will be unavailable outside of that context. E.g.,
a REST API endpoint is unable to query an asset conditionally registered
within WP Admin.
Other information:
Jetpack product discussion
N/A, none available.
Does this pull request change what data or activity we track or use?
No
Testing instructions:
Perform the testing outlined in the following relevant PRs: