Skip to content

Sharing: update the sharing button settings to clarify the available options (block or legacy sharing buttons).#36473

Merged
jeherve merged 1 commit intotrunkfrom
fix/sharing-block-settings-info
Mar 20, 2024
Merged

Sharing: update the sharing button settings to clarify the available options (block or legacy sharing buttons).#36473
jeherve merged 1 commit intotrunkfrom
fix/sharing-block-settings-info

Conversation

@jeherve
Copy link
Copy Markdown
Member

@jeherve jeherve commented Mar 20, 2024 •
edited
Loading

Follow-up to #34619

Proposed changes:

There are currently 2 main options for sharing buttons:

  • The legacy sharing buttons, the preferrable option when you use a legacy/classic theme.
  • The sharing buttons block, when you use a block-based theme.

We've tried to highlight the 2 options in #34619, but the wording mentioning "below" for a link that in fact lead to the site editor was confusing. This commit updates the wording and introduces a notice instead of a basic paragraph text that may be missed.

before after
image image
image image

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

  • p1710919627851779/1710908290.326479-slack-C06DN6QQVAQ

Does this pull request change what data or activity we track or use?

  • No

Testing instructions:

You will need to test the Jetpack > Settings > Sharing screen in different scenarios:

  1. When using a classic theme like Twenty Fifteen and the sharing module off.
  2. When using a classic theme like Twenty Fifteen and the sharing module on
  3. When using a block-based theme like Twenty Twenty Four and the sharing module off.
  4. When using a block-based theme like Twenty Twenty Four and the sharing
    module on.

@jeherve
Sharing: clarify 2 options in settings
02f9f13 
There are currently 2 main options for sharing buttons:

- The legacy sharing buttons, the preferrable option when you use a legacy/classic theme.
- The sharing buttons block, when you use a block-based theme.

We've tried to highlight the 2 options in #34619, but the wording mentioning "below" for a link that in fact lead to the site editor was confusing. This commit updates the wording and introduces a notice instead of a basic paragraph text that may be missed.
@jeherve jeherve added Bug When a feature is broken and / or not performing as intended [Feature] Sharing Post sharing, sharing buttons [Status] Needs Review This PR is ready for review. [Pri] Normal [Status] Needs Team Review Obsolete. Use Needs Review instead. labels Mar 20, 2024
@jeherve jeherve requested a review from a team March 20, 2024 08:03
@jeherve jeherve self-assigned this Mar 20, 2024
@github-actions github-actions Bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ Admin Page React-powered dashboard under the Jetpack menu labels Mar 20, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 20, 2024

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team Review" label and ask someone from your team review the code. Once reviewed, it can then be merged.
If you need an extra review from someone familiar with the codebase, you can update the labels from "[Status] Needs Team Review" to "[Status] Needs Review", and in that case Jetpack Approvers will do a final review of your PR.

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen daily.
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for April 2, 2024 (scheduled code freeze on April 1, 2024).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 20, 2024 •
edited
Loading

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the fix/sharing-block-settings-info branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack fix/sharing-block-settings-info

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

taipeicoder
taipeicoder approved these changes Mar 20, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@taipeicoder taipeicoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended 🚀!
Screenshot 2024-03-20 at 4 11 03 PM

Screenshot 2024-03-20 at 4 11 13 PM

@jeherve jeherve merged commit 2793b2e into trunk Mar 20, 2024
@jeherve jeherve deleted the fix/sharing-block-settings-info branch March 20, 2024 09:09
@github-actions github-actions Bot added this to the jetpack/13.3 milestone Mar 20, 2024
@github-actions github-actions Bot removed [Status] Needs Review This PR is ready for review. [Status] Needs Team Review Obsolete. Use Needs Review instead. labels Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taipeicoder taipeicoder taipeicoder approved these changes

Assignees

@jeherve jeherve

Labels

Admin Page React-powered dashboard under the Jetpack menu Bug When a feature is broken and / or not performing as intended [Feature] Sharing Post sharing, sharing buttons [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Normal

Projects

None yet

Milestone

jetpack/13.3

Development

Successfully merging this pull request may close these issues.

2 participants

@jeherve @taipeicoder