Stats: update Stats script to be valid XHTML#3489
Merged
eliorivero merged 1 commit intomasterfrom Mar 4, 2016
Merged
Conversation
In XHTML, attribute minimization is forbidden. `async` and `defer` must be defined as `<script async='async' defer='defer'>`. Suggested here: https://wordpress.org/support/topic/doesnt-work-with-xhtml-2
|
You can use empty strings (or any value), like |
Contributor
|
@eligrey it's more self-documented to make the value explicit for the attribute, so we'll stick to |
|
@eliorivero @jeherve This issue has regressed. When site stats are enabled on my site, Jetpack emits |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In XHTML, attribute minimization is forbidden.
asyncanddefermust be defined as<script async='async' defer='defer'>.Suggested here:
https://wordpress.org/support/topic/doesnt-work-with-xhtml-2