Conversation
* Only shows the price when the price information is available * Support cache busting from the get_product method * Renew product cache if tiers are enabled but there is no tier info on the cache * Add changelog file * Check for wp_error on feature data to handle Jetpack not being connected
* Rename Token_Subscript_Service to Abstract_Token_Subscription_Service * changelog * Allow old class just in case * `use` classes at the top to shorten up the class check.
Contributor
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
zinigor
commented
Dec 25, 2023
| "automattic/jetpack-sync": "@dev", | ||
| "automattic/jetpack-videopress": "@dev", | ||
| "automattic/jetpack-waf": "@dev", | ||
| "automattic/jetpack-wordads": "@dev", |
Contributor
Author
There was a problem hiding this comment.
this doesn't look right.
CGastrell
approved these changes
Dec 25, 2023
Contributor
CGastrell
left a comment
There was a problem hiding this comment.
Seems all janitorial, if you feel comfortable, ![]()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Proposed changes:
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: