Skip to content

Comments: Always use https for jetpack.wordpress.com#3475

Merged
zinigor merged 1 commit intomasterfrom
fix/jp-comments-url-scheme
Mar 2, 2016
Merged

Comments: Always use https for jetpack.wordpress.com#3475
zinigor merged 1 commit intomasterfrom
fix/jp-comments-url-scheme

Conversation

@kraftbj
Copy link
Copy Markdown
Contributor

@kraftbj kraftbj commented Feb 29, 2016

jetpack.wordpress.com forces https now. We can save an http request by always loading directly from https.

@kraftbj kraftbj added Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Comments [Status] Needs Review This PR is ready for review. labels Feb 29, 2016
@kraftbj kraftbj added this to the 3.9.3 milestone Feb 29, 2016
@eliorivero eliorivero added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Mar 1, 2016
@zinigor zinigor merged this pull request into master Mar 2, 2016
@zinigor zinigor deleted the fix/jp-comments-url-scheme branch March 2, 2016 08:22
@zinigor zinigor removed the [Status] Ready to Merge Go ahead, you can push that green button! label Mar 2, 2016
@kraftbj kraftbj restored the fix/jp-comments-url-scheme branch March 8, 2016 16:37
@kraftbj kraftbj deleted the fix/jp-comments-url-scheme branch March 8, 2016 16:40
@georgestephanis
Copy link
Copy Markdown
Contributor

Good catch, @kraftbj!

Incidentally, this also fixes a window.postMessage error. Without it, the postMessage origin protocols won't match on non-https sites (it expects, http, finds https) so the comment form won't resize correctly and such.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants