Skip to content

CRM: Resolves 2874 - handle missing transaction status#30644

Merged
cleacos merged 4 commits intotrunkfrom
fix/crm/2874-handle_missing_transaction_status
May 15, 2023
Merged

CRM: Resolves 2874 - handle missing transaction status#30644
cleacos merged 4 commits intotrunkfrom
fix/crm/2874-handle_missing_transaction_status

Conversation

@tbradsha
Copy link
Copy Markdown
Contributor

@tbradsha tbradsha commented May 11, 2023

Resolves Automattic/zero-bs-crm#2874 - handle missing transaction status

Proposed changes:

If a transaction was synced with an unofficial status, the transaction status dropdown when editing will show as if the initial status is selected (generally "Succeeded").

This PR adds the unofficial status to the dropdown so that it accurately reflects the current transaction status.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  1. Create a transaction with an unofficial status (e.g. use DevTools to edit the select options).
  2. View the transaction editor.

In trunk the status will appear to be "Succeeded".

In fix/crm/2874-handle_missing_transaction_status the status will be the unofficial status you used.

@tbradsha tbradsha added [Status] Needs Team Review Obsolete. Use Needs Review instead. [Plugin] CRM Issues about the Jetpack CRM plugin labels May 11, 2023
@tbradsha tbradsha requested a review from a team May 11, 2023 16:54
@tbradsha tbradsha self-assigned this May 11, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 11, 2023 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ⚠️ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

Crm plugin:

  • Next scheduled release: June 6, 2023.
  • Scheduled code freeze: May 29, 2023.

@tbradsha tbradsha force-pushed the fix/crm/2874-handle_missing_transaction_status branch 2 times, most recently from 2b320eb to c1617d2 Compare May 11, 2023 17:15
@cleacos
Copy link
Copy Markdown
Contributor

cleacos commented May 12, 2023

Is this PR ready to review? I don't see any file to check.

@tbradsha
Copy link
Copy Markdown
Contributor Author

tbradsha commented May 12, 2023

For some reason 321a802 showed as empty. Repushed that commit.

@cleacos cleacos self-requested a review May 12, 2023 16:48
cleacos
cleacos previously approved these changes May 12, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@cleacos cleacos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works as expected.

LGTM!

@tbradsha
Copy link
Copy Markdown
Contributor Author

tbradsha commented May 12, 2023

A PHP notice was making tests fail. @cleacos care to check again? ;^)

@tbradsha tbradsha force-pushed the fix/crm/2874-handle_missing_transaction_status branch from a52e010 to 2322878 Compare May 12, 2023 20:31
cleacos
cleacos approved these changes May 15, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@cleacos cleacos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approved!!

@cleacos cleacos merged commit 6078a98 into trunk May 15, 2023
@cleacos cleacos deleted the fix/crm/2874-handle_missing_transaction_status branch May 15, 2023 09:17
@github-actions github-actions bot removed the [Status] Needs Team Review Obsolete. Use Needs Review instead. label May 15, 2023
@github-actions github-actions bot added this to the crm/5.7.1 milestone May 15, 2023
@tbradsha tbradsha mentioned this pull request Sep 6, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cleacos cleacos cleacos approved these changes

Assignees

@tbradsha tbradsha

Labels

[CRM] Portal Module [CRM] WooSync Module [Plugin] CRM Issues about the Jetpack CRM plugin

Projects

None yet

Milestone

crm/5.8.0

Development

Successfully merging this pull request may close these issues.

2 participants

@tbradsha @cleacos