Skip to content

Update React peer deps to v18#28924

Merged
anomiex merged 7 commits intotrunkfrom
update/react-peer-deps
Feb 22, 2023
Merged

Update React peer deps to v18#28924
anomiex merged 7 commits intotrunkfrom
update/react-peer-deps

Conversation

@anomiex
Copy link
Copy Markdown
Contributor

@anomiex anomiex commented Feb 13, 2023

Proposed changes:

When #28710 updated the React dependencies, our packages' peer dependencies were overlooked. Update them too.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

None, but see #28710

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • 🤷

@anomiex
Update React peer deps to v18
c3bd837 
When #28710 updated the React dependencies, our packages' peer
dependencies were overlooked. Update them too.
@anomiex anomiex added Bug When a feature is broken and / or not performing as intended [Status] Needs Review This PR is ready for review. [Pri] Normal labels Feb 13, 2023
@anomiex anomiex self-assigned this Feb 13, 2023
@anomiex anomiex enabled auto-merge (squash) February 13, 2023 17:43
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 13, 2023 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ All commits were linted before commit.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped.
Then, add the "[Status] Needs Team review" label and ask someone from your team review the code.
Once you’ve done so, switch to the "[Status] Needs Review" label; someone from Jetpack Crew will then review this PR and merge it to be included in the next Jetpack release.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 13, 2023 •
edited
Loading

Are you an Automattician? You can now test your Pull Request on WordPress.com. On your sandbox, run

bin/jetpack-downloader test jetpack update/react-peer-deps

to get started. More details: p9dueE-5Nn-p2

zinigor
zinigor previously approved these changes Feb 21, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@zinigor zinigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks OK, but we probably have to rebase or re-try this one.

zinigor
zinigor previously approved these changes Feb 21, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@zinigor zinigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've manually bumped versions to match with trunk.

@anomiex
Copy link
Copy Markdown
Contributor Author

anomiex commented Feb 21, 2023

Had to fix a version number, so it needs re-approval

@anomiex anomiex merged commit d46a696 into trunk Feb 22, 2023
@anomiex anomiex deleted the update/react-peer-deps branch February 22, 2023 14:51
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@sdixon194 sdixon194 sdixon194 approved these changes

@zinigor zinigor zinigor left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@anomiex anomiex

Labels

Bug When a feature is broken and / or not performing as intended [JS Package] Components [JS Package] Connection [JS Package] IDC [JS Package] Partner Coupon [JS Package] Publicize Components [Pri] Normal RNA

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anomiex @zinigor @sdixon194