Site Icon: Play nicely with Core's feature#2328
Closed
Conversation
69e71d8 to
0a0e7af
Compare
Contributor
|
I've rebased this so it's easier to test without all the 4.3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #2326
These methods should be considered temporary until a full-scale deprecation is possible when 4.3 is the minimum version of WordPress. The aim is something we can ship before 4.3 launches so we play nicely together while determining the long-term plan.
Idea:
if ( function_exists( 'has_site_icon' ) && ! jetpack_has_site_icon() ). Serving as a 4.3 version check and if the user has already set our icon. If true, then hide our uploader and maybe filterjetpack_site_icon_urlto Core's in the event someone is using us after a function_exists check?