Sync: Update whitelist/blacklist#16166
Conversation
|
Caution: This PR has changes that must be merged to WordPress.com |
|
Thank you for the great PR description! When this PR is ready for review, please apply the E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-16166 Scheduled Jetpack release: August 4, 2020. |
3472d8b to
1a321bd
Compare
1a321bd to
ef50cfa
Compare
503b5a8 to
decfded
Compare
decfded to
df28c46
Compare
leogermani
left a comment
There was a problem hiding this comment.
Thanks for this PR!
I ran the tests and everything works fine.
- Full sync
- syncing edits in posts and options
Made some minor comments in the code
I think all the versions in @deprecated and @since tags must be updated to 8.8.0.
| * @module json-api | ||
| * | ||
| * @since 3.8.2 | ||
| * @deprecated 8.7.0 |
There was a problem hiding this comment.
* @deprecated 8.8.0
Should it be 8.8?
|
|
||
| // Publicize filter to prevent publicizing blacklisted post types. | ||
| add_filter( 'publicize_should_publicize_published_post', array( __CLASS__, 'prevent_publicize_blacklisted_posts' ), 10, 2 ); | ||
| // Publicize filter to prevent publicizing b;pcled post types. |
There was a problem hiding this comment.
// Publicize filter to prevent publicizing blocked post types.
typo
|
|
||
| /** | ||
| * Get default capabilities whitelist. | ||
| * Get default capabilities allowlist.. |
There was a problem hiding this comment.
- Get default capabilities allowlist.
Extra dot at the end
| * @param bool Is the option a site option. | ||
| */ | ||
| if ( ! in_array( $this->option_name, apply_filters( 'jetpack_options_whitelist', Defaults::$default_options_whitelist, $this->site_option ) ) ) { | ||
| $allowlist = apply_filters_deprecated( 'jetpack_options_whitelist', array( Defaults::$default_options_allowlist, $this->site_option ), 'Jetpack 8.7.0', 'jetpack_options_allowlist' ); |
There was a problem hiding this comment.
$allowlist = apply_filters_deprecated( 'jetpack_options_whitelist', array( Defaults::$default_options_allowlist, $this->site_option ), 'jetpack-8.8.0', 'jetpack_options_allowlist' );
| * | ||
| * @module json-api | ||
| * | ||
| * @since 8.7.0 |
|
This PR has been marked as stale. This happened because:
No further action is needed. But it's worth checking if this PR has clear testing instructions, is it up to date with master, and it is still valid. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation. |
Supports #16099
Changes proposed in this Pull Request:
Is this a new feature or does it add/remove features to an existing part of Jetpack?
Does this pull request change what data or activity we track or use?
No change.
Testing instructions:
Proposed changelog entry for your changes: