Skip to content

SEO Tools: Re-term 'grandfather' to 'legacy'#16050

Merged
kraftbj merged 1 commit into
masterfrom
update/docs-grandfather
Jun 3, 2020
Merged

SEO Tools: Re-term 'grandfather' to 'legacy'#16050
kraftbj merged 1 commit into
masterfrom
update/docs-grandfather

Conversation

@kraftbj

@kraftbj kraftbj commented Jun 3, 2020

Copy link
Copy Markdown
Contributor

In examining language use with Jetpack, the term 'grandfathering' has historical origins that are not proper.

This PR renames usage of the term.

Changes proposed in this Pull Request:

  • Changes 'grandfather' to 'legacy'/

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • pb6Nl-duS-p2

Does this pull request change what data or activity we track or use?

No.

Testing instructions:

  • None.

Proposed changelog entry for your changes:

  • Remove use of the term 'grandfathering' for a more precise 'legacy'.

@kraftbj kraftbj added [Feature] SEO Tools Tools for improving a site's search engine optimization. [Status] Needs Review This PR is ready for review. Enhancement Changes to an existing feature — removing, adding, or changing parts of it labels Jun 3, 2020
@kraftbj kraftbj self-assigned this Jun 3, 2020
@kraftbj kraftbj requested a review from folletto June 3, 2020 14:54
@matticbot

matticbot commented Jun 3, 2020

Copy link
Copy Markdown
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello kraftbj! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D44349-code before merging this PR. Thank you!
This revision will be updated with each commit to this PR

@jetpackbot

jetpackbot commented Jun 3, 2020

Copy link
Copy Markdown
Collaborator

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-16050

Scheduled Jetpack release: July 7, 2020.
Scheduled code freeze: June 30, 2020

Generated by 🚫 dangerJS against acc617a

folletto
folletto approved these changes Jun 3, 2020
View reviewed changes

@folletto folletto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't do a proper code review, but as far as I can tell being a simple rename, seems good to go for me 👍

brbrr
brbrr approved these changes Jun 3, 2020
View reviewed changes

@brbrr brbrr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brbrr brbrr added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Jun 3, 2020
@kraftbj kraftbj added this to the 8.7 milestone Jun 3, 2020
@kraftbj kraftbj merged commit 2cbd9df into master Jun 3, 2020
@kraftbj kraftbj deleted the update/docs-grandfather branch June 3, 2020 20:41
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Jun 3, 2020
@kraftbj

kraftbj commented Jun 3, 2020

Copy link
Copy Markdown
Contributor Author

r208436-wpcom

@kraftbj kraftbj mentioned this pull request Jun 8, 2020
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@folletto folletto folletto approved these changes
@brbrr brbrr brbrr approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@kraftbj kraftbj

Labels

Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] SEO Tools Tools for improving a site's search engine optimization. Touches WP.com Files

Projects

None yet

Milestone

8.7

Development

Successfully merging this pull request may close these issues.

6 participants

@kraftbj @matticbot @jetpackbot @folletto @brbrr @jeherve