Skip to content

Recipes: take into account new Lazy attribute that may be added#15366

Merged
jeherve merged 1 commit intomasterfrom
fix/recipe-test-loading
Apr 8, 2020
Merged

Recipes: take into account new Lazy attribute that may be added#15366
jeherve merged 1 commit intomasterfrom
fix/recipe-test-loading

Conversation

@jeherve
Copy link
Copy Markdown
Member

@jeherve jeherve commented Apr 8, 2020

Changes proposed in this Pull Request:

Core now adds a new lazy attribute that we must take into account in tests.

See https://core.trac.wordpress.org/changeset/47554

Testing instructions:

  • Do the tests pass?

Proposed changelog entry for your changes:

  • N/A

@jeherve jeherve added Bug When a feature is broken and / or not performing as intended [Feature] Shortcodes / Embeds [Status] Needs Review This PR is ready for review. [Pri] BLOCKER labels Apr 8, 2020
@jeherve jeherve added this to the 8.5 milestone Apr 8, 2020
@jeherve jeherve requested a review from a team April 8, 2020 09:35
@jeherve jeherve self-assigned this Apr 8, 2020
@jetpackbot
Copy link
Copy Markdown
Collaborator

jetpackbot commented Apr 8, 2020 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: May 5, 2020.
Scheduled code freeze: April 28, 2020

Generated by 🚫 dangerJS against aeac049

@jeherve jeherve added [Status] In Progress and removed [Status] Needs Review This PR is ready for review. labels Apr 8, 2020
@jeherve jeherve force-pushed the fix/recipe-test-loading branch 4 times, most recently from c9d495a to 233673d Compare April 8, 2020 11:11
@matticbot
Copy link
Copy Markdown
Contributor

matticbot commented Apr 8, 2020

Caution: This PR has changes that must be merged to WordPress.com
Hello jeherve! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D41568-code before merging this PR. Thank you!

@jeherve jeherve force-pushed the fix/recipe-test-loading branch 2 times, most recently from 09d52a7 to 4fd504b Compare April 8, 2020 11:25
@jeherve jeherve force-pushed the fix/recipe-test-loading branch from 4fd504b to aeac049 Compare April 8, 2020 11:38
@jeherve jeherve added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels Apr 8, 2020
brbrr
brbrr approved these changes Apr 8, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@brbrr brbrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brbrr brbrr added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Apr 8, 2020
@jeherve jeherve merged commit 17601a5 into master Apr 8, 2020
@jeherve jeherve deleted the fix/recipe-test-loading branch April 8, 2020 12:59
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Apr 8, 2020
@kbrown9 kbrown9 mentioned this pull request Apr 8, 2020
Merged
@kraftbj
Copy link
Copy Markdown
Contributor

kraftbj commented May 14, 2020

r207473-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@brbrr brbrr brbrr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jeherve jeherve

Labels

Bug When a feature is broken and / or not performing as intended [Feature] Shortcodes / Embeds [Pri] BLOCKER Touches WP.com Files

Projects

None yet

Milestone

8.5

Development

Successfully merging this pull request may close these issues.

5 participants

@jeherve @jetpackbot @matticbot @kraftbj @brbrr