Skip to content

Search: Add search plan onboarding notice#15074

Closed
gibrown wants to merge 5 commits intoadd/search-planfrom
add/search-onboarding
Closed

Search: Add search plan onboarding notice#15074
gibrown wants to merge 5 commits intoadd/search-planfrom
add/search-onboarding

Conversation

@gibrown
Copy link
Copy Markdown
Member

@gibrown gibrown commented Mar 20, 2020

Adding banner to thank the end user for their purchase.

We redirect after Calypso thank you screen and link to: http://gibrown.wpsandbox.me/main/wp-admin/admin.php?page=jetpack&search-thank-you#/performance

Still TBD: handle dismissing the notification.

@gibrown gibrown added this to the InstantSearchLaunch milestone Mar 20, 2020
@gibrown gibrown requested a review from a team March 20, 2020 18:12
@matticbot
Copy link
Copy Markdown
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello gibrown! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D40623-code before merging this PR. Thank you!

@gibrown gibrown changed the base branch from master to instant-search-master March 20, 2020 18:13
@jetpackbot
Copy link
Copy Markdown
Collaborator

Warnings
⚠️ "Testing instructions" are missing for this PR. Please add some
⚠️ "Proposed changelog entry" is missing for this PR. Please include any meaningful changes

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against 23132c8d958f656f31f40e67ab1513a89172ffef

@keoshi
Copy link
Copy Markdown
Contributor

keoshi commented Mar 23, 2020

@gibrown Pushed a few changes to use a Card component for the Search onboarding. A few notes:

  • I've not added the full show/hide Card logic here.
  • On jetpack-notices I'm calling the new SearchOnboarding component for ease of use. I'm guessing that's not where we want to call it.
  • Also noticed the component shows up on any and all sections of the Jetpack app as long as the URL contains ?search-thank-you.

Desktop:

image

Tablet:

image

Mobile:

image

@gibrown gibrown changed the base branch from instant-search-master to add/search-plan March 24, 2020 21:14
@gibrown gibrown changed the title Search: Add search plan onboarding notice and api calls Search: Add search plan onboarding notice Mar 24, 2020
@gibrown
Copy link
Copy Markdown
Member Author

gibrown commented Mar 24, 2020

If we just use a query param then I don't think there is any reason we need to store whether this has been dismissed or not anywhere, so maybe just clear the query param with something like:

	dismissCard = () => {
		const query = decode( window.location.search.substring( 1 ) );
		if ( 'search-thank-you' in query ) {
			delete query['search-thank-you'];
		}
		window.location.search = encode( query );
		analytics.tracks.recordJetpackClick( {
			target: 'search-onboarding',
			button: 'dismiss',
			page: this.props.path,
		} );
	};

Though I suspect there is a better way to do this.

@keoshi
Copy link
Copy Markdown
Contributor

keoshi commented Mar 25, 2020

That's a valid point — it depends on whether we want to make it semi-persistent or a one-time thing — but I agree we can show it just once right after purchase.

@AnnaMag
Copy link
Copy Markdown
Contributor

AnnaMag commented Mar 26, 2020

As per agreement to display the Thank you note in the purchase flow in Calypso, closing this PR (for now).

@keoshi keoshi deleted the add/search-onboarding branch July 15, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Search For all things related to Search

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants