Instant Search: improve search phrase highlighting (#2)#13824
Instant Search: improve search phrase highlighting (#2)#13824
Conversation
This is an automated check which relies on |
jsnmoon
left a comment
There was a problem hiding this comment.
Neat; works as expected.
jeherve
left a comment
There was a problem hiding this comment.
This looks good to me. Merging.
pre-commit hook was skipped for one or more commits
I would suggest running yarn build in your local install, so the pre-commit hook is available whenever you commit something.
|
Thanks for merging @jeherve!
I do have |
Fixes #13792.
Changes proposed in this Pull Request:
We recently switched to use
<mark>to show where search results contain the search phrase. It looks like this by default:This PR changes the highlighting to have a more subtle appearance:
Is this a new feature or does it add/remove features to an existing part of Jetpack?
No - it's a visual adjustment to an unreleased feature.
Testing instructions
Add define( "JETPACK_SEARCH_PROTOTYPE", true ); to your wp-config.php.
If using Jetpack's Docker development environment, you can create a file at /docker/mu-plugins/instant-search.php and add the define there.
Ensure that your site has the Jetpack Pro plan and Jetpack Search enabled.
You can enable Jetpack Search in the Performance tab within the Jetpack menu (/wp-admin/admin.php?page=jetpack#/performance).
Perform a search and make sure the correct highlighting is applied. For example: /?s=card&blog_id=84860689 should show the word "card" bolded in results.
Proposed changelog entry for your changes: