Skip to content

Jetpack Authors Widget - improve Author/Post text hierarchy and styling#13719

Closed
joanrho wants to merge 2 commits intomasterfrom
update/jetpack-authors-widget-styling
Closed

Jetpack Authors Widget - improve Author/Post text hierarchy and styling#13719
joanrho wants to merge 2 commits intomasterfrom
update/jetpack-authors-widget-styling

Conversation

@joanrho
Copy link
Copy Markdown
Contributor

@joanrho joanrho commented Oct 10, 2019

Changes proposed in this Pull Request:

This updates the styling of the Jetpack Authors block by removing the bullets, improving the hierarchy between the author and posts by adjusting the margins and padding between items, and removing the left margin from the widget.

Fixes #13718

Before/After
Screen Shot 2019-10-10 at 4 38 34 PM

Testing instructions:

  • Check out this PR on a site with Jetpack and Twenty Twenty theme installed
  • Go to Jetpack Settings > Writing (at SITE_URL/wp-admin/admin.php?page=jetpack#/writing) and switch on both toggles under Widgets
  • Go to Appearance > Widgets and add the "Authors (Jetpack)" widget to your site wherever you want
  • See that the Authors widget looks like the above "After" mockup.

Proposed changelog entry for your changes:

  • None needed

@joanrho joanrho added Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review This PR is ready for review. [Status] Design Review Complete [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack labels Oct 10, 2019
@joanrho joanrho added this to the 7.9 milestone Oct 10, 2019
@joanrho joanrho requested review from a team and MichaelArestad October 10, 2019 22:48
@joanrho joanrho self-assigned this Oct 10, 2019
@jetpackbot
Copy link
Copy Markdown
Collaborator

jetpackbot commented Oct 10, 2019 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: November 5, 2019.
Scheduled code freeze: October 29, 2019

Generated by 🚫 dangerJS against 694f352

jeherve
jeherve requested changes Oct 11, 2019
View reviewed changes
@jeherve jeherve added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Oct 11, 2019
jeherve
jeherve requested changes Oct 11, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think those changes make sense with a theme like Twenty Twenty, but they may not be the best thing for other themes. If you look at Twenty Ten for example, here is how things look like before your patch:

image

And after:

image

What would you think about including those changes just for the Twenty Twenty theme, here:
https://github.com/Automattic/jetpack/pull/13516/files#diff-f193e7fb576a947927effb72e2a5b6f8R116

@joanrho joanrho mentioned this pull request Oct 17, 2019
Merged
5 tasks
@jeherve
Copy link
Copy Markdown
Member

jeherve commented Oct 21, 2019

closing in favor of #13516

@jeherve jeherve closed this Oct 21, 2019
@jeherve jeherve deleted the update/jetpack-authors-widget-styling branch October 21, 2019 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeherve jeherve jeherve requested changes

@MichaelArestad MichaelArestad Awaiting requested review from MichaelArestad

Assignees

@joanrho joanrho

Labels

Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack [Status] Design Review Complete [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements.

Projects

None yet

Milestone

7.9

Development

Successfully merging this pull request may close these issues.

Jetpack Authors Widget - improve Author/Post text hierarchy

3 participants

@joanrho @jetpackbot @jeherve