Conversation
This comment has been minimized.
This comment has been minimized.
Member
|
I think we may want to do the same for |
Contributor
Author
|
There are probably more, but at least let's land this and we can iterate as we have more mental cycles to give to this. |
jeherve
approved these changes
Oct 17, 2019
Member
|
Thanks for these changes! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP: Opening this so we can continue the discussion of rules to exclude or modify.
Adding changes to Code Climate to match what maintenance checks we'd like to use at this time.
See https://docs.codeclimate.com/docs/advanced-configuration
Changes proposed in this Pull Request:
Testing instructions:
Proposed changelog entry for your changes: