Shortcodes: Clean up Crowdsignal oEmbed regex#11540
Merged
Conversation
Collaborator
|
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: April 2, 2019. |
zinigor
approved these changes
Mar 12, 2019
Contributor
zinigor
left a comment
There was a problem hiding this comment.
Looking at Core files, this makes sense, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jetpack is adding a couple of oEmbeds regexes that are already included by Core.
Note survey.fm is included in Core, but the regex doesn't include subdomains, so this needs to stay until https://core.trac.wordpress.org/ticket/46467 is in a minimum version of WP.
Changes proposed in this Pull Request:
Testing instructions:
Proposed changelog entry for your changes: