Scope a test to pre-5.0 WordPress versions#10860
Merged
dereksmart merged 2 commits intomasterfrom Dec 6, 2018
Merged
Conversation
…d this code (and test). Lets skip the test in 5.0 and we can review the code need later. Related https://core.trac.wordpress.org/ticket/33121
dereksmart
reviewed
Dec 6, 2018
Collaborator
|
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: January 10, 2019. Generated by 🚫 dangerJS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In WordPress 5.0 all data- attributes are allowed so we no longer need this code (and test).
Related https://core.trac.wordpress.org/ticket/33121
Changes proposed in this Pull Request:
Testing instructions:
Proposed changelog entry for your changes:
No changelog needed