Skip to content

Synchronized the media summary class code.#10083

Merged
zinigor merged 2 commits intomasterfrom
sync/media-summary
Aug 31, 2018
Merged

Synchronized the media summary class code.#10083
zinigor merged 2 commits intomasterfrom
sync/media-summary

Conversation

@zinigor
Copy link
Copy Markdown
Contributor

@zinigor zinigor commented Aug 30, 2018

Brings the media summary class code in sync with WordPress.com, no major logic changes here except for the break replacement with continue.

@zinigor zinigor added Enhancement Changes to an existing feature — removing, adding, or changing parts of it General [Status] Needs Review This PR is ready for review. labels Aug 30, 2018
@zinigor zinigor requested review from a team and gibrown as code owners August 30, 2018 22:04
@zinigor zinigor force-pushed the sync/media-summary branch from 9331934 to 1c22fd0 Compare August 30, 2018 22:05
@jetpackbot
Copy link
Copy Markdown
Collaborator

Warnings
⚠️

"Testing instructions" are missing for this PR. Please add some

⚠️

"Proposed changelog entry" is missing for this PR. Please include any meaningful changes

This is automated check which relies on PULL_REQUEST_TEMPLATE.We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS

Copy link
Copy Markdown
Member

@mdawaffe mdawaffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to stick with break: #10037

So let's flip it and make the change on WP.com.

@zinigor
Copy link
Copy Markdown
Contributor Author

zinigor commented Aug 31, 2018

Thanks @mdawaffe , I missed that one. Fixed now!

@zinigor zinigor merged commit dc3e81b into master Aug 31, 2018
@zinigor zinigor deleted the sync/media-summary branch August 31, 2018 20:06
@jeherve jeherve added this to the 6.6 milestone Sep 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Changes to an existing feature — removing, adding, or changing parts of it General

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants