Allow post lock dialog to return and retain functionality#32
Merged
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +19 B (0%) Total Size: 1.93 MB
ℹ️ View Unchanged
|
ingeniumed
reviewed
Sep 22, 2025
| return null; | ||
| } | ||
|
|
||
| if ( window.__experimentalEnableSync ) { |
There was a problem hiding this comment.
I'm trying to think about what this PR would look like when we want to get this into core. Would this change be accepted by the Gutenberg folks, given instead of doing window.<access flag here> they are adding a filter for plugin users? If it is accepted, what would it look like when we want to move it out of the experiment stage and have it be a core feature? How would null be returned then?
Author
There was a problem hiding this comment.
I would imagine it being either similar to the isLocked check directly above. Currently the override just short-circuits any logic in here, so either way, it would require refactor.
There was a problem hiding this comment.
Could you add a todo about this? That way it's known and we have an idea of how to approach it?
chriszarate
approved these changes
Sep 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Directly overrides post lock modal and returns when in experimental sync (collaborative editing) mode.
Why?
In Automattic/vip-real-time-collaboration#6 we introduced a method to override the post lock modal, but this resulted in the functionality within the post lock modal being lost also.
How?
Returns early on setting check.
Testing Instructions