Add accessible-focus library to enable keyboard focus styling#87
Merged
Add accessible-focus library to enable keyboard focus styling#87
accessible-focus library to enable keyboard focus styling#87Conversation
…antage of existing (but currently unused) focus styles
accessibility-focus library to enable keyboard focus stylingaccessible-focus library to enable keyboard focus styling
Contributor
|
Tested a bit in Jetpack, it works well and seems like a really good idea, it makes outlines more prominent but only when it's needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was testing jetpack & noticed there wasn't very good focus styling for keyboard navigation, but there was support for it in quite a few existing components. It looks like some components that were imported use calypso's accessible-focus library, which drops a class onto
htmlwhen the keyboard is used. I've ported that library over to dops-components, and updated the classes to usedops-accessible-focusin line with the rest of the class names.This isn't really testable on its own, but I'll open a Jetpack PR shortly to enable it in JP.