Merged
Conversation
scruffian
commented
Nov 19, 2021
|
|
||
| function create_blockbase_child_admin_notice_error() { | ||
| $class = 'notice notice-error'; | ||
| $message = __( 'Please specify a theme name.', 'create-blockbase-theme' ); |
Contributor
Author
There was a problem hiding this comment.
Sometimes you can get in here for other errors, but only ones that users shouldn't hit unless they are doing something dodgy!
Closed
Contributor
|
Should we add a |
7c95504 to
308a508
Compare
Contributor
Author
|
Done! |
Contributor
|
Something is not working, I get the success message but I don't get a zip! |
Contributor
Author
are you running GB trunk? |
Contributor
yep! |
Contributor
Author
|
I dont think this will work against trunk because of the key change from user to custom - it's probably throwing a fatal error. |
Contributor
|
I just tried with the latest version from the dotorg repo and it's the same. It's 12.0.0, on a fresh site too. |
Contributor
Author
|
i just pushed a fix. Such a silly mistake! 🤦 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds some security fixes:
Fixes #15