Fix strlen crashing when argument is not string#158
Merged
chrean merged 1 commit intoAutomattic:masterfrom Nov 23, 2021
Merged
Conversation
chrean
approved these changes
Nov 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
0.3.7 introduce a breaking change where the strlen util function can no longer handle non-string arguments. It attempts to pass the argument to
stripAnsiregardless which returns null. It then attempts .split, which crashes when str is not a string. This should ensure that does not happen by always guaranteeing the argument tostripAnsiis a string. This will resolve #152 and #157Checklist
Please make sure the items below have been covered before requesting a review:
Deploy Notes
Notes regarding deployment of this PR, if any.
Steps to Test or Reproduce
Added unit tests to confirm the
strlenfunction can handle both string and non-string arguments, which was causing the error previouslyExample: