Skip to content

Performance/RegexpCompare: remove redundant condition#761

Merged
GaryJones merged 1 commit into
developfrom
fix/regexcompare-remove-redundant-condition
Aug 23, 2023
Merged

Performance/RegexpCompare: remove redundant condition#761
GaryJones merged 1 commit into
developfrom
fix/regexcompare-remove-redundant-condition

Conversation

@jrfnl

@jrfnl jrfnl commented Aug 22, 2023

Copy link
Copy Markdown
Collaborator

This condition will always be true if one of the previous conditions is true, so is redundant.

This condition will always be `true` if one of the previous conditions is `true`, so is redundant.
@jrfnl jrfnl added this to the 2.3.4 milestone Aug 22, 2023
@jrfnl jrfnl requested a review from a team as a code owner August 22, 2023 23:13

@GaryJones GaryJones left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GaryJones GaryJones merged commit 3e73ba2 into develop Aug 23, 2023
@GaryJones GaryJones deleted the fix/regexcompare-remove-redundant-condition branch August 23, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants