CS: remove yoda conditions from VIPCS codebase#571
Merged
Conversation
In contrast to WPCS, disallow the use of Yoda conditions.
Fixes made with the auto-fixer available in the Slevomat standard via the `SlevomatCodingStandard.ControlStructures.DisallowYodaComparison` sniff and visually reviewed.
GaryJones
approved these changes
Jul 30, 2020
GaryJones
left a comment
Contributor
There was a problem hiding this comment.
Approving, but would like @rebeccahum to chip in on this one.
Collaborator
Author
|
@rebeccahum Please see the discussion Gary and me had about this on Slack for context. |
Contributor
|
Since it seems like yoda is a preferential coding style, I'm fine with disabling the warning on the non-usage of it. However, is it necessary to enforce the usage of it when writing sniffs (I'm assuming for consistency)? |
Collaborator
Author
@rebeccahum I presume you mean "enforce that yoda conditions aren't used" ? Necessary: no, helpful for keeping the codebase consistent: yes. |
rebeccahum
approved these changes
Jul 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHPCS ruleset: forbid yoda conditions in VIPCS codebase
In contrast to WPCS, disallow the use of Yoda conditions.
CS: change yoda conditions to non-yoda
Fixes made with the auto-fixer available in the Slevomat standard via the
SlevomatCodingStandard.ControlStructures.DisallowYodaComparisonsniff and visually reviewed.