fix: Add dev-server:url-detected to EventType by patrick-patel · Pull Request #808 · AutoMaker-Org/automaker

patrick-patel · 2026-02-25T02:45:28Z

Summary

Resolve TypeScript build failure when building the server/Electron app.

Add dev-server:url-detected to the EventType union in libs/types/src/event.ts
The dev-server service already emitted this event when detecting a dev server URL from output; the missing type caused the build error

Testing

npm run build:server passes
npm run format:check passes

Summary by CodeRabbit

Chores
- Internal reordering of an event type declaration to improve code clarity; no change to available events or runtime behavior.
Notes
- No user-visible changes or new features in this release.

The dev-server-service emits this event when a dev server URL is detected from output; the type was missing from the EventType union and caused a TypeScript build error. Co-authored-by: Cursor <cursoragent@cursor.com>

gemini-code-assist · 2026-02-25T02:45:46Z

Summary of Changes

Hello @patrick-patel, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a TypeScript build failure that occurred when compiling the server/Electron application. The fix involves explicitly adding the dev-server:url-detected event type to the EventType union, which was previously causing build errors due to its absence or incorrect definition in the type system, despite the event already being emitted by the dev-server service.

Highlights

TypeScript Build Fix: Resolved a TypeScript build failure in the server/Electron application by ensuring the dev-server:url-detected event type is correctly defined.
Event Type Definition: Added the dev-server:url-detected string literal to the EventType union in libs/types/src/event.ts.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

libs/types/src/event.ts
- Ensured the dev-server:url-detected event type is part of the EventType union.

Activity

The author confirmed that npm run build:server passes after the changes.
The author verified that npm run format:check passes, ensuring code style compliance.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

coderabbitai · 2026-02-25T02:45:47Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e28b538 and 5931b37.

📒 Files selected for processing (1)

libs/types/src/event.ts

🚧 Files skipped from review as they are similar to previous changes (1)

libs/types/src/event.ts

📝 Walkthrough

Walkthrough

Reordered the EventType union in libs/types/src/event.ts: the literal 'dev-server:stopped' was moved from after 'dev-server:output' to after 'dev-server:url-detected'. No literals were added or removed.

Changes

Cohort / File(s)	Summary
Event Type Definition `libs/types/src/event.ts`	Reordered the `EventType` union members: moved `'dev-server:stopped'` to follow `'dev-server:url-detected'`. No additions or deletions of literals.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 I nudged a tiny event in line,
A hop, a shuffle—now it's fine.
No new words, just a small rearrange,
Quiet change in the event range. 🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The PR title claims to 'Add dev-server:url-detected' but the summary shows only a reordering of existing EventType members with no actual addition.	Update the PR title to accurately reflect the change, such as 'refactor: Reorder EventType members' or clarify if this PR should add the missing member.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings (stacked PR)
📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

gemini-code-assist

Code Review

The code changes involve reordering the 'dev-server:url-detected' event type within the EventType definition in libs/types/src/event.ts. There were no review comments provided.

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@libs/types/src/event.ts`:
- Around line 51-53: The EventType union in libs/types/src/event.ts contains a
duplicate literal 'dev-server:url-detected'; open the EventType declaration (the
union of string literals) and remove the repeated 'dev-server:url-detected'
entry so it only appears once, ensuring the EventType union remains the same
otherwise and keeping surrounding commas/formatting intact.

ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0330c70 and e28b538.

📒 Files selected for processing (1)

libs/types/src/event.ts

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

fix: Add dev-server:url-detected to EventType

e28b538

The dev-server-service emits this event when a dev server URL is detected from output; the type was missing from the EventType union and caused a TypeScript build error. Co-authored-by: Cursor <cursoragent@cursor.com>

gemini-code-assist Bot reviewed Feb 25, 2026

View reviewed changes

coderabbitai Bot reviewed Feb 25, 2026

View reviewed changes

Comment thread libs/types/src/event.ts Outdated

Update libs/types/src/event.ts

5931b37

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

gsxdsm merged commit 6b97219 into AutoMaker-Org:v0.15.0rc Feb 25, 2026
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Add dev-server:url-detected to EventType#808

fix: Add dev-server:url-detected to EventType#808
gsxdsm merged 2 commits intoAutoMaker-Org:v0.15.0rcfrom
patrick-patel:fix/dev-server-event-type

patrick-patel commented Feb 25, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

gemini-code-assist Bot commented Feb 25, 2026

Uh oh!

coderabbitai Bot commented Feb 25, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

❌ Failed checks (1 warning)

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

patrick-patel commented Feb 25, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing

Summary by CodeRabbit

Uh oh!

gemini-code-assist Bot commented Feb 25, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

coderabbitai Bot commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

❌ Failed checks (1 warning)

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

patrick-patel commented Feb 25, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Feb 25, 2026 •

edited

Loading