Skip to content

fix: prevent refresh button from overlapping close button in Dev Server dialog#610

Merged
stefandevo merged 2 commits intov0.13.0rcfrom
fix/dev-server-dialog-button-overlap
Jan 19, 2026
Merged

fix: prevent refresh button from overlapping close button in Dev Server dialog#610
stefandevo merged 2 commits intov0.13.0rcfrom
fix/dev-server-dialog-button-overlap

Conversation

@stefandevo
Copy link
Copy Markdown
Collaborator

@stefandevo stefandevo commented Jan 19, 2026

Summary

Fixes the button overlap issue in the Dev Server dialog header where the refresh button was positioned on top of the close button, making the close button inaccessible.

Fixes #579

Changes

  • Added compact prop to DialogContent which positions the close button at top-2 right-3
  • Added pr-10 (right padding) to DialogHeader to ensure the refresh button doesn't overlap with the close button
  • Adjusted vertical padding from py-3 to py-2.5 for better visual balance with compact mode

Before

The refresh button (circular arrow icon) overlaps the dialog's close button in the top right corner.

After

Both buttons are visible and clickable with appropriate spacing between them.

Summary by CodeRabbit

  • Style
    • Tightened layout and spacing in the dev server logs panel for a more compact, consistent visual presentation (reduced header padding and denser content spacing).

✏️ Tip: You can customize this high-level summary in your review settings.

…er dialog

Use compact mode for DialogContent and add right padding to the header
to ensure the refresh button doesn't overlap with the dialog close button.

Fixes #579
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @stefandevo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a user interface bug within the Dev Server dialog where interactive elements were overlapping, hindering usability. The changes ensure that both the refresh and close buttons are clearly visible and accessible by adjusting their positioning and spacing through component properties and CSS utility classes, thereby improving the overall user experience of the dialog.

Highlights

  • UI Fix: Resolved an issue in the Dev Server dialog where the refresh button was overlapping and obscuring the close button, making it inaccessible.
  • DialogContent Component: Introduced a new compact prop to the DialogContent component, which repositions the close button for better spacing.
  • DialogHeader Styling: Applied pr-10 (right padding) to the DialogHeader to prevent the refresh button from overlapping the close button and adjusted vertical padding from py-3 to py-2.5 for improved visual balance.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jan 19, 2026

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

📝 Walkthrough

Walkthrough

A single-file UI layout adjustment to the Dev Server logs dialog: tightened header vertical padding, added right padding, and enabled compact dialog content to prevent the refresh button from overlapping the close button.

Changes

Cohort / File(s) Summary
Dev Server Logs Panel Layout Fixes
apps/ui/src/components/views/board-view/worktree-panel/components/dev-server-logs-panel.tsx
Added compact attribute to DialogContent, removed p-0, reduced DialogHeader padding from py-3 to py-2.5, and added pr-10 to create spacing between refresh and close buttons.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 In a snug little dialog where buttons once sparred,
A nibble of padding now plays the right card.
Refresh hops aside, the close gives a wink,
Space found its manners—no overlap to think. ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: preventing refresh button overlap with the close button in the Dev Server dialog.
Linked Issues check ✅ Passed The PR changes directly address issue #579 by adding compact attribute, adjusting header spacing with pr-10 padding, and tuning py-3 to py-2.5 to prevent button overlap.
Out of Scope Changes check ✅ Passed All changes are scoped to the dev-server-logs-panel component and directly address the button overlap issue; no unrelated modifications detected.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes a UI issue where the refresh and close buttons in the Dev Server dialog overlapped. The changes correctly reposition the close button and add padding to prevent the overlap. My review includes one suggestion to correct an unintended layout change caused by the modifications, ensuring the dialog content renders as expected.

@stefandevo stefandevo merged commit 0d92594 into v0.13.0rc Jan 19, 2026
8 checks passed
@stefandevo stefandevo deleted the fix/dev-server-dialog-button-overlap branch January 19, 2026 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant