fix: feature.json corruption on crash lose#532
Conversation
Shironex
commented
Jan 16, 2026
- Closes [Bug]: Feature.json corruption on crash loses task progress and makes features disappear #518
- Introduced atomic write functionality for JSON files to ensure data integrity during writes. - Added recovery mechanisms to read JSON files with fallback options for corrupted or missing files. - Enhanced existing services to utilize atomic write and recovery features for improved reliability. - Updated tests to cover new atomic writing and recovery scenarios, ensuring robust error handling and data consistency.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @Shironex, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a critical improvement to data integrity by introducing atomic file operations with backup and recovery capabilities for JSON files. Specifically targeting Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a robust solution to prevent feature.json corruption by implementing atomic writes and reads with recovery capabilities. The new atomic-writer.ts utility is well-designed, providing atomic operations with backup and recovery from temporary files or backups, which significantly enhances data integrity. These changes have been consistently applied across various services, replacing direct file system access with the new safer utilities. The inclusion of a comprehensive test suite for the new atomic writer is also a great addition, ensuring the reliability of this critical component. The overall quality of the implementation is high. As a suggestion for future improvement, the private loadFeature method within AutoModeService could also be updated to use the new featureLoader.get() method to ensure all feature loading paths are protected against file corruption.