feat: implement XML extraction utilities and enhance feature handling by Shironex · Pull Request #527 · AutoMaker-Org/automaker

Shironex · 2026-01-16T21:56:16Z

Introduced a new xml-extractor module with functions for XML parsing, including escaping/unescaping XML characters, extracting sections and elements, and managing implemented features.
Added functionality to add, remove, update, and check for implemented features in the app_spec.txt file.
Enhanced the create and update feature handlers to check for duplicate titles and trigger synchronization with app_spec.txt on status changes.
Updated tests to cover new XML extraction utilities and feature handling logic, ensuring robust functionality and reliability.
Closes [Feature Request] Sync verified features back to app_spec.txt #153

- Introduced a new xml-extractor module with functions for XML parsing, including escaping/unescaping XML characters, extracting sections and elements, and managing implemented features. - Added functionality to add, remove, update, and check for implemented features in the app_spec.txt file. - Enhanced the create and update feature handlers to check for duplicate titles and trigger synchronization with app_spec.txt on status changes. - Updated tests to cover new XML extraction utilities and feature handling logic, ensuring robust functionality and reliability.

coderabbitai · 2026-01-16T21:56:22Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

gemini-code-assist · 2026-01-16T21:56:38Z

Summary of Changes

Hello @Shironex, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the application's ability to manage and persist feature specifications by introducing a dedicated XML extraction and manipulation module. It integrates robust XML parsing capabilities with the feature management system, ensuring that app_spec.txt accurately reflects implemented features and preventing data inconsistencies like duplicate feature titles. This foundational work streamlines feature lifecycle management and enhances data integrity.

Highlights

New XML Extraction Utilities: Introduced a new xml-extractor module with comprehensive functions for XML parsing, including character escaping/unescaping, and extraction of sections and elements from XML content.
Enhanced Feature Management in app_spec.txt: Implemented robust functionality within the xml-extractor module to add, remove, update, and check for implemented features directly within the app_spec.txt file.
Duplicate Title Prevention: Enhanced both the feature creation and update handlers to include checks for duplicate feature titles, preventing the creation of features with identical names.
Automated app_spec.txt Synchronization: Integrated logic to automatically synchronize feature details with the app_spec.txt file when a feature's status changes to 'verified' or 'completed'.
Comprehensive Test Coverage: Added extensive unit tests for the new XML extraction utilities and the updated feature handling logic to ensure reliability and correctness.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a new xml-extractor module for parsing and manipulating app_spec.txt, and integrates it into the feature handling logic. The changes include adding, removing, and updating features in the XML, as well as checking for duplicate feature titles to improve data integrity. The feature lifecycle is also enhanced to automatically sync with app_spec.txt when a feature's status changes to 'verified' or 'completed'. The new functionality is well-tested. My review focuses on improving the robustness of the new XML parsing utilities, particularly around handling multiline content, and suggests a minor improvement for code maintainability.

gemini-code-assist · 2026-01-16T21:58:09Z

+  const log = options.logger || logger;
+  const values: string[] = [];
+
+  const regex = new RegExp(`<${tagName}>(.*?)<\\/${tagName}>`, 'g');


The regex (.*?) does not match newlines. This means that if an XML element's content spans multiple lines, it will not be extracted correctly. You should use ([\s\S]*?) to match any character, including newlines, similar to what you've done in extractXmlSection.

Suggested change

const regex = new RegExp(`<${tagName}>(.*?)<\\/${tagName}>`, 'g');

const regex = new RegExp(`<${tagName}>([\s\S]*?)<\\/${tagName}>`, 'g');

gemini-code-assist · 2026-01-16T21:58:09Z

+    // Extract name
+    const nameMatch = featureContent.match(/<name>(.*?)<\/name>/);
+    const name = nameMatch ? unescapeXml(nameMatch[1].trim()) : '';
+
+    // Extract description
+    const descMatch = featureContent.match(/<description>(.*?)<\/description>/);
+    const description = descMatch ? unescapeXml(descMatch[1].trim()) : '';


Similar to the issue in extractXmlElements, the regex (.*?) used to extract the name and description of a feature does not handle multiline content. If a feature's name or description spans multiple lines in the XML, it will be parsed incorrectly. You should use ([\s\S]*?) to correctly handle multiline content.

Suggested change

// Extract name

const nameMatch = featureContent.match(/<name>(.*?)<\/name>/);

const name = nameMatch ? unescapeXml(nameMatch[1].trim()) : '';

// Extract description

const descMatch = featureContent.match(/<description>(.*?)<\/description>/);

const description = descMatch ? unescapeXml(descMatch[1].trim()) : '';

// Extract name

const nameMatch = featureContent.match(/<name>([\s\S]*?)<\/name>/);

const name = nameMatch ? unescapeXml(nameMatch[1].trim()) : '';

// Extract description

const descMatch = featureContent.match(/<description>([\s\S]*?)<\/description>/);

const description = descMatch ? unescapeXml(descMatch[1].trim()) : '';

gemini-code-assist · 2026-01-16T21:58:09Z

+  const i1 = indent;
+  const i2 = indent + indent;
+  const i3 = indent + indent + indent;
+  const i4 = indent + indent + indent + indent;


The manual creation of indentation levels i1 through i4 is a bit rigid and can be hard to maintain if more levels are needed. Using indent.repeat(n) would make the code more flexible and readable.

Suggested change

const i1 = indent;

const i2 = indent + indent;

const i3 = indent + indent + indent;

const i4 = indent + indent + indent + indent;

const i1 = indent;

const i2 = indent.repeat(2);

const i3 = indent.repeat(3);

const i4 = indent.repeat(4);

gemini-code-assist · 2026-01-16T21:58:09Z

+      it('should handle elements across multiple lines', () => {
+        const xml = `<items>
+          <item>
+            first
+          </item>
+          <item>second</item>
+        </items>`;
+        // Note: multiline content in single element may not be captured due to . not matching newlines
+        const result = extractXmlElements(xml, 'item');
+        expect(result).toHaveLength(1); // Only matches single-line content
+        expect(result[0]).toBe('second');
+      });


This test case confirms the buggy behavior of extractXmlElements with multiline content, as noted in the comment. Tests should assert the desired correct behavior, not confirm existing bugs. After fixing the regex in extractXmlElements to handle multiline content, this test should be updated to assert that multiline content is extracted correctly.

it('should handle elements across multiple lines', () => { const xml = `<items> <item> first </item> <item>second</item> </items>`; const result = extractXmlElements(xml, 'item'); expect(result).toEqual(['first', 'second']); });

Shironex self-assigned this Jan 16, 2026

Shironex added the Enhancement Improvements to existing functionality or UI. label Jan 16, 2026

gemini-code-assist Bot reviewed Jan 16, 2026

View reviewed changes

fix: adress pr comments

50ed405

Shironex merged commit 6bb0461 into v0.12.0rc Jan 16, 2026
5 of 6 checks passed

Shironex deleted the feature/v0.12.0rc-1768598412391-lnp7 branch January 16, 2026 22:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: implement XML extraction utilities and enhance feature handling#527

feat: implement XML extraction utilities and enhance feature handling#527
Shironex merged 2 commits intov0.12.0rcfrom
feature/v0.12.0rc-1768598412391-lnp7

Shironex commented Jan 16, 2026

Uh oh!

coderabbitai Bot commented Jan 16, 2026 •

edited

Loading

Review skipped

Other AI code review bot(s) detected

Uh oh!

gemini-code-assist Bot commented Jan 16, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Jan 16, 2026

Uh oh!

gemini-code-assist Bot Jan 16, 2026

Uh oh!

gemini-code-assist Bot Jan 16, 2026

Uh oh!

gemini-code-assist Bot Jan 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	const regex = new RegExp(`<${tagName}>(.*?)<\\/${tagName}>`, 'g');
	const regex = new RegExp(`<${tagName}>([\s\S]*?)<\\/${tagName}>`, 'g');

Conversation

Shironex commented Jan 16, 2026

Uh oh!

coderabbitai Bot commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Other AI code review bot(s) detected

Uh oh!

gemini-code-assist Bot commented Jan 16, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

coderabbitai Bot commented Jan 16, 2026 •

edited

Loading