Walkthrough

The changes improve Windows compatibility by implementing OS-aware PATH configuration in the Git pre-commit hook, updating the OpenCode provider to use npx.cmd on Windows with shell execution enabled, and modifying subprocess handling to treat npx and npm as requiring shell invocation on Windows.

Changes

Suggested labels

Testers-Requested

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 Hoppy Windows paths we trace,
Commands leap with proper grace,
Shell and cmd files now align,
Cross-platform magic, oh so fine!
On any OS, Node will run,
Our rabbit work is finally done! 🌟

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

• 📝 Generate docstrings

libs/platform/src/subprocess.ts (1)

204-206: Consider extracting the duplicated needsShell logic.

This condition is identical to the one in spawnJSONLProcess (lines 48-50). Extracting it to a helper function would improve maintainability.

♻️ Optional refactor to extract helper

+/**
+ * Determine if a command needs shell execution on Windows
+ */
+function needsWindowsShell(command: string): boolean {
+  return (
+    process.platform === 'win32' &&
+    (command.toLowerCase().endsWith('.cmd') || command === 'npx' || command === 'npm')
+  );
+}
+
 export async function* spawnJSONLProcess(options: SubprocessOptions): AsyncGenerator<unknown> {
   // ...
-  const needsShell =
-    process.platform === 'win32' &&
-    (command.toLowerCase().endsWith('.cmd') || command === 'npx' || command === 'npm');
+  const needsShell = needsWindowsShell(command);
   // ...
 }

 export async function spawnProcess(options: SubprocessOptions): Promise<SubprocessResult> {
   // ...
-  const needsShell =
-    process.platform === 'win32' &&
-    (command.toLowerCase().endsWith('.cmd') || command === 'npx' || command === 'npm');
+  const needsShell = needsWindowsShell(command);
   // ...
 }

apps/server/src/providers/opencode-provider.ts (2)

754-756: Consider using case-insensitive check for consistency.

The subprocess.ts uses toLowerCase().endsWith('.cmd'), but this check is case-sensitive. While unlikely to cause issues since the command is explicitly set to lowercase npx.cmd, aligning the checks would be more defensive.

♻️ Optional: case-insensitive check

-        shell: process.platform === 'win32' && command.endsWith('.cmd'),
+        shell: process.platform === 'win32' && command.toLowerCase().endsWith('.cmd'),

---

989-991: Same optional refinement as above for case-insensitivity.

♻️ Optional: case-insensitive check

-        shell: process.platform === 'win32' && command.endsWith('.cmd'),
+        shell: process.platform === 'win32' && command.toLowerCase().endsWith('.cmd'),

Configuration used: defaults

Review profile: CHILL

Plan: Pro

• X
• Mastodon
• Reddit
• LinkedIn

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.