fix: add API key header to verifySession for Electron auth#383
fix: add API key header to verifySession for Electron auth#383
Conversation
The verifySession() function was not including the X-API-Key header when making requests to /api/settings/status, causing Electron mode to fail authentication on app startup despite having a valid API key. This resulted in users seeing "You've been logged out" screen immediately after launching the Electron app. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @Shironex, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical authentication bug in the Electron application mode. By ensuring the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly adds the X-API-Key header to the verifySession function, fixing an authentication issue in Electron mode. The change is straightforward and addresses the root cause. I've added one suggestion to make the authentication header logic more robust and consistent with other parts of the codebase by ensuring that only one authentication token is sent per request.
Summary
X-API-Keyheader toverifySession()functionRoot Cause
The
verifySession()function inhttp-api-client.tswas not including theX-API-Keyheader when checking authentication status. In Electron mode, authentication uses API key headers, not session cookies. This caused/api/settings/statusto return 401, triggering the logged-out screen.Test plan
🤖 Generated with Claude Code