Conversation
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
There was a problem hiding this comment.
Pull request overview
Release-please generated release PR to publish SynthOrg v0.5.6, updating the project’s canonical version markers and changelog to reflect the new release (notably the log aggregation/shipping feature set from #964).
Changes:
- Bump SynthOrg package version to
0.5.6. - Update Commitizen version to
0.5.6for consistent tagging. - Add the
0.5.6entry to the GitHub changelog and update the release-please manifest.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/synthorg/__init__.py |
Bumps __version__ to 0.5.6 (source of truth for dynamic versioning). |
pyproject.toml |
Updates Commitizen’s version to 0.5.6 for release/tag consistency. |
.github/CHANGELOG.md |
Adds the 0.5.6 release notes entry referencing #964. |
.github/.release-please-manifest.json |
Updates the release-please manifest version to 0.5.6. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches. Re-running this action after a short time may resolve the issue. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
There was a problem hiding this comment.
Code Review
This pull request increments the project version from 0.5.5 to 0.5.6 across the manifest, pyproject.toml, and package initialization files, while also updating the changelog with log aggregation and shipping features. A critical issue was identified regarding the use of Python 2-style exception handling syntax in several files, which will cause runtime crashes in Python 3 and must be corrected before the release is finalized.
| [tool.commitizen] | ||
| name = "cz_conventional_commits" | ||
| version = "0.5.5" # x-release-please-version | ||
| version = "0.5.6" # x-release-please-version |
There was a problem hiding this comment.
This release includes code with Python 2 syntax for exception handling, which is a syntax error in Python 3 and will cause runtime crashes. This should be fixed before finalizing the release.
For example, src/synthorg/settings/service.py on line 626 has:
except MemoryError, RecursionError:The correct Python 3 syntax is:
except (MemoryError, RecursionError):This issue is also present in src/synthorg/settings/subscribers/observability_subscriber.py on lines 127, 156, 180, and 213.
Since this is a critical issue that affects the stability of the release, I'm flagging it here. It's recommended to fix these syntax errors across the codebase.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #967 +/- ##
=======================================
Coverage 91.93% 91.93%
=======================================
Files 643 643
Lines 34897 34897
Branches 3423 3423
=======================================
Hits 32082 32082
Misses 2211 2211
Partials 604 604 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
81b077a to
07c716a
Compare
07c716a to
5b8c424
Compare
5b8c424 to
b61f835
Compare
b61f835 to
4d6673c
Compare
e87f7a7 to
4120218
Compare
91360b5 to
cddf603
Compare
|
🤖 Created releases: 🌻 |
🤖 I have created a release beep boop
0.5.6 (2026-04-02)
Features
Maintenance
This PR was generated with Release Please. See documentation.