Dependency Review

Scanned Files

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the spending summary models by introducing a common base class. This change centralizes the definition of shared aggregation fields, reducing duplication and making the codebase more modular and easier to maintain. The refactoring ensures that all related models consistently handle their core spending metrics while allowing for dimension-specific extensions.

Highlights

• Code Refactoring: Extracted a new private base class, _SpendingTotals, to encapsulate shared aggregation fields (total_cost_usd, total_input_tokens, total_output_tokens, record_count) common to spending summary models.
• Model Inheritance: AgentSpending, DepartmentSpending, and PeriodSpending models now inherit from _SpendingTotals, eliminating redundant field definitions and promoting code reuse.
• Documentation Update: Updated DESIGN_SPEC.md to reflect the adoption of the 'Shared field groups' convention (M2.5) and the implementation of the _SpendingTotals base class.
• Code Reduction: Achieved a net reduction of 41 lines of code without introducing any behavioral changes, improving maintainability.
• Pydantic Configuration: The model_config = ConfigDict(frozen=True) is now defined once in the base class and inherited by all subclasses, ensuring consistent immutability.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Greptile Summary

This PR is a clean structural refactor that extracts a private _SpendingTotals base class to eliminate the four duplicated aggregation fields (total_cost_usd, total_input_tokens, total_output_tokens, record_count) previously copy-pasted across AgentSpending, DepartmentSpending, and PeriodSpending. The accompanying DESIGN_SPEC.md updates are accurate and consistent.

• _SpendingTotals centralises model_config = ConfigDict(frozen=True) and the four shared fields with their constraints; all three subclasses now only define their dimension-specific identifier field(s).
• PeriodSpending._validate_period_ordering is preserved without modification.
• __init__.py exports remain unchanged; _SpendingTotals is correctly excluded.
• Note: As flagged in an earlier review thread, Pydantic v2 serialises parent fields before subclass fields, so model_dump() / model_dump_json() now emit the totals fields before the identifier fields (agent_id, department_name, start/end). Deserialization is unaffected, but any snapshot tests doing string-level JSON comparison would need updating.
• One minor design gap: _SpendingTotals is directly instantiable (all fields have defaults) despite the docstring prohibiting it — consider enforcing this constraint at runtime.

Confidence Score: 4/5

• Safe to merge — pure structural refactor with no behavioral changes to validation logic, field constraints, or public API.
• The change is well-scoped: it only reorganises inheritance without touching any business logic, validators, or public exports. The existing test suite covers frozen behaviour, defaults, validators, and JSON roundtrip. The one point deducted is for the silent field-ordering change in serialized output (noted in a prior thread) and the unenforced "not for direct instantiation" contract on _SpendingTotals, both of which are low-risk but worth addressing before the class is reused further.
• src/ai_company/budget/spending_summary.py — specifically the directly-instantiable _SpendingTotals base class and the serialization field-order change.

Important Files Changed

Class Diagram

%%{init: {'theme': 'neutral'}}%%
classDiagram
    class _SpendingTotals {
        +float total_cost_usd
        +int total_input_tokens
        +int total_output_tokens
        +int record_count
        model_config: frozen=True
    }

    class PeriodSpending {
        +datetime start
        +datetime end
        _validate_period_ordering()
    }

    class AgentSpending {
        +NotBlankStr agent_id
    }

    class DepartmentSpending {
        +NotBlankStr department_name
    }

    class SpendingSummary {
        +PeriodSpending period
        +tuple~AgentSpending~ by_agent
        +tuple~DepartmentSpending~ by_department
        +float budget_total_monthly
        +float budget_used_percent
        +BudgetAlertLevel alert_level
        model_config: frozen=True
        _validate_unique_agent_ids()
        _validate_unique_department_names()
    }

    _SpendingTotals <|-- PeriodSpending
    _SpendingTotals <|-- AgentSpending
    _SpendingTotals <|-- DepartmentSpending
    SpendingSummary o-- PeriodSpending
    SpendingSummary o-- AgentSpending
    SpendingSummary o-- DepartmentSpending

_{Last reviewed commit: 3fa29a7}