Skip to content

chore: audit full web dashboard for hardcoded design token violations #938

@Aureliolo

Description

@Aureliolo

Problem

During the Settings redesign (#936), we discovered 23 hardcoded spacing values (px-4 py-3, gap-4, space-y-4) across settings files that should use density-aware design tokens (p-card, gap-grid-gap, gap-section-gap). This is likely a codebase-wide issue affecting all pages.

Scope

  1. Full audit: Scan every .tsx file in web/src/ for hardcoded spacing that should use density tokens:

    • Card padding: px-N py-N on card containers -> p-card
    • Section gaps: space-y-N / gap-N between sections -> gap-section-gap
    • Grid gaps: gap-N in grid layouts -> gap-grid-gap
    • Font families: any fontFamily or non-token font -> font-sans / font-mono
  2. Audit agent: Create a review agent (for /pre-pr-review and /aurelio-review-pr) that:

    • Scans all changed web/src/**/*.tsx files
    • Flags hardcoded px-N py-N on card/section containers that should be p-card
    • Flags hardcoded gap-N / space-y-N at section/grid level that should use density tokens
    • Reports violations with file:line and suggested fix
    • Runs as part of the pre-PR agent roster

Acceptance Criteria

  • All existing pages use density tokens for card padding, section gaps, grid gaps
  • New audit agent created in .claude/agents/ for theme token enforcement
  • Agent integrated into /pre-pr-review skill roster
  • Agent integrated into /aurelio-review-pr skill
  • Zero hardcoded card/section/grid spacing in web/src/

Metadata

Metadata

Assignees

No one assigned

    Labels

    prio:mediumShould do, but not blockingscope:webVue 3 dashboardtype:choreMaintenance, cleanup, dependency updatesv0.5Minor version v0.5v0.5.3Patch release v0.5.3

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions