-
Notifications
You must be signed in to change notification settings - Fork 0
chore: audit full web dashboard for hardcoded design token violations #938
Copy link
Copy link
Closed
Labels
prio:mediumShould do, but not blockingShould do, but not blockingscope:webVue 3 dashboardVue 3 dashboardtype:choreMaintenance, cleanup, dependency updatesMaintenance, cleanup, dependency updatesv0.5Minor version v0.5Minor version v0.5v0.5.3Patch release v0.5.3Patch release v0.5.3
Description
Problem
During the Settings redesign (#936), we discovered 23 hardcoded spacing values (px-4 py-3, gap-4, space-y-4) across settings files that should use density-aware design tokens (p-card, gap-grid-gap, gap-section-gap). This is likely a codebase-wide issue affecting all pages.
Scope
-
Full audit: Scan every
.tsxfile inweb/src/for hardcoded spacing that should use density tokens:- Card padding:
px-N py-Non card containers ->p-card - Section gaps:
space-y-N/gap-Nbetween sections ->gap-section-gap - Grid gaps:
gap-Nin grid layouts ->gap-grid-gap - Font families: any
fontFamilyor non-token font ->font-sans/font-mono
- Card padding:
-
Audit agent: Create a review agent (for
/pre-pr-reviewand/aurelio-review-pr) that:- Scans all changed
web/src/**/*.tsxfiles - Flags hardcoded
px-N py-Non card/section containers that should bep-card - Flags hardcoded
gap-N/space-y-Nat section/grid level that should use density tokens - Reports violations with file:line and suggested fix
- Runs as part of the pre-PR agent roster
- Scans all changed
Acceptance Criteria
- All existing pages use density tokens for card padding, section gaps, grid gaps
- New audit agent created in
.claude/agents/for theme token enforcement - Agent integrated into
/pre-pr-reviewskill roster - Agent integrated into
/aurelio-review-prskill - Zero hardcoded card/section/grid spacing in
web/src/
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
prio:mediumShould do, but not blockingShould do, but not blockingscope:webVue 3 dashboardVue 3 dashboardtype:choreMaintenance, cleanup, dependency updatesMaintenance, cleanup, dependency updatesv0.5Minor version v0.5Minor version v0.5v0.5.3Patch release v0.5.3Patch release v0.5.3