-
Notifications
You must be signed in to change notification settings - Fork 0
refactor: extract shared file-filtering logic from semantic analyzers #859
Copy link
Copy link
Closed
Labels
scope:smallLess than 1 day of workLess than 1 day of worktype:refactorCode restructuring, cleanupCode restructuring, cleanupv0.5Minor version v0.5Minor version v0.5
Description
Summary
Both AstSemanticAnalyzer.analyze and LlmSemanticAnalyzer.analyze contain identical file extension filtering and max_files slicing logic. This was partially addressed in #611 (extracted _filter_files in semantic_analyzer.py) but the LLM analyzer still has its own copy.
Finding source
Pre-PR review agents (type-design-analyzer, python-reviewer) flagged this during #611 review.
Proposed fix
Import and use the _filter_files function from semantic_analyzer.py in semantic_llm.py, or move it to a shared utility location.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
scope:smallLess than 1 day of workLess than 1 day of worktype:refactorCode restructuring, cleanupCode restructuring, cleanupv0.5Minor version v0.5Minor version v0.5