-
Notifications
You must be signed in to change notification settings - Fork 0
chore: add allow_inf_nan=False to core Task and AcceptanceCriterion models #844
Copy link
Copy link
Closed
Labels
prio:lowNice to have, can deferNice to have, can deferscope:smallLess than 1 day of workLess than 1 day of worktype:choreMaintenance, cleanup, dependency updatesMaintenance, cleanup, dependency updates
Description
Context
The core Task and AcceptanceCriterion models in src/synthorg/core/task.py use ConfigDict(frozen=True) without allow_inf_nan=False. This means float fields on Task (e.g., budget-related) could accept inf/NaN values.
Most other frozen models in the project include allow_inf_nan=False as a defensive setting.
Proposed Fix
Add allow_inf_nan=False to both Task and AcceptanceCriterion model configs. Verify no existing tests or fixtures rely on inf/NaN values.
Source
Found during PR #832 review (CodeRabbit round 5).
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
prio:lowNice to have, can deferNice to have, can deferscope:smallLess than 1 day of workLess than 1 day of worktype:choreMaintenance, cleanup, dependency updatesMaintenance, cleanup, dependency updates