-
Notifications
You must be signed in to change notification settings - Fork 0
feat: wire RootConfig.git_clone to GitCloneTool instantiation #507
Copy link
Copy link
Closed
Labels
prio:mediumShould do, but not blockingShould do, but not blockingscope:smallLess than 1 day of workLess than 1 day of workspec:toolsDESIGN_SPEC Section 11 - Tool & Capability SystemDESIGN_SPEC Section 11 - Tool & Capability Systemtype:featureNew feature implementationNew feature implementation
Description
Summary
RootConfig now carries a git_clone: GitCloneNetworkPolicy field and GitCloneTool.__init__ accepts a network_policy parameter, but the engine layer does not pass the config-supplied policy when instantiating GitCloneTool. The tool always uses the default policy (GitCloneNetworkPolicy()), making the YAML-configured hostname_allowlist non-functional.
Context
Added in #505 (SSRF prevention for git clone URLs). The tools layer is complete — this is engine-layer wiring.
Scope
- In whatever engine/workspace component instantiates git tools, pass
config.git_cloneas thenetwork_policyargument when constructingGitCloneTool - Add integration test verifying the config flows through
Design Spec Reference
- §11.1.1 Built-in git tools
Notes
The default policy is maximally restrictive (block all private IPs, empty allowlist), so this is not a security regression. It means the allowlist cannot be used until this wiring is added.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
prio:mediumShould do, but not blockingShould do, but not blockingscope:smallLess than 1 day of workLess than 1 day of workspec:toolsDESIGN_SPEC Section 11 - Tool & Capability SystemDESIGN_SPEC Section 11 - Tool & Capability Systemtype:featureNew feature implementationNew feature implementation