Skip to content

fix: correct API reference link path in rest-api.md#320

Merged
Aureliolo merged 1 commit intomainfrom
fix/mkdocs-api-reference-link
Mar 12, 2026
Merged

fix: correct API reference link path in rest-api.md#320
Aureliolo merged 1 commit intomainfrom
fix/mkdocs-api-reference-link

Conversation

@Aureliolo
Copy link
Copy Markdown
Owner

Summary

  • Fix broken link in docs/rest-api.md: ../_generated/api-reference.html_generated/api-reference.html
  • The ../ prefix resolved outside the MkDocs docs tree, causing mkdocs build --strict to abort with a warning
  • This broke both the GitHub Pages and PR Preview workflows on main

Test plan

  • Verified locally: uv run mkdocs build --strict passes clean with no warnings

The link used `../_generated/api-reference.html` which resolves outside
the docs tree in MkDocs source-relative resolution. The generated file
lives at `docs/_generated/api-reference.html`, so the correct path from
`docs/rest-api.md` is `_generated/api-reference.html` (no `../` prefix).

This broke `mkdocs build --strict` (GitHub Pages + PR Preview workflows).
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue where the API reference link in the documentation was incorrectly formed, leading to build failures in both local development environments and CI/CD pipelines. By adjusting the relative path, the documentation now builds successfully, ensuring that the API reference is accessible and the project's documentation workflows remain operational.

Highlights

  • Broken Link Fix: Corrected the API reference link path in docs/rest-api.md by removing the ../ prefix, which was causing mkdocs build --strict to abort with a warning and breaking GitHub Pages and PR Preview workflows.
Changelog
  • docs/rest-api.md
    • Fixed the API reference link path from ../_generated/api-reference.html to _generated/api-reference.html.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 12, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 8ead398e-0a31-42ae-b63c-5433335470bf

📥 Commits

Reviewing files that changed from the base of the PR and between 77cdbcc and 3827707.

📒 Files selected for processing (1)
  • docs/rest-api.md
📜 Recent review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Greptile Review
🔇 Additional comments (1)
docs/rest-api.md (1)

5-5: Correct relative path; this fix looks good.

Removing the parent-directory prefix matches the docs tree layout and should stop MkDocs from resolving the link outside the site root.


📝 Walkthrough

Summary by CodeRabbit

Documentation

  • Fixed the REST API Reference link path to resolve correctly to the API documentation.

Walkthrough

A relative path in an REST API reference link within the documentation was corrected from a parent-directory reference (../) to a relative reference in the same directory structure.

Changes

Cohort / File(s) Summary
Documentation Link Adjustment
docs/rest-api.md
Updated REST API reference anchor link path from "../_generated/api-reference.html" to "_generated/api-reference.html" for proper relative path navigation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and accurately describes the main change: correcting the API reference link path in rest-api.md from an incorrect relative path to a correct one.
Description check ✅ Passed The description is directly related to the changeset, explaining the link fix, the root cause (incorrect path resolution), the impact on workflows, and the verification method.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/mkdocs-api-reference-link
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch fix/mkdocs-api-reference-link

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request corrects a broken link in the documentation file docs/rest-api.md. The change removes an incorrect ../ from the link path to the generated API reference page. This resolves an issue that caused the documentation build to fail. The fix is correct and well-contained. No issues were found in this change.

@Aureliolo Aureliolo temporarily deployed to cloudflare-preview March 12, 2026 11:14 — with GitHub Actions Inactive
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.64%. Comparing base (77cdbcc) to head (3827707).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #320   +/-   ##
=======================================
  Coverage   93.64%   93.64%           
=======================================
  Files         427      427           
  Lines       19177    19177           
  Branches     1846     1846           
=======================================
  Hits        17959    17959           
  Misses        943      943           
  Partials      275      275           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@greptile-apps
Copy link
Copy Markdown

greptile-apps bot commented Mar 12, 2026

Greptile Summary

This PR fixes a broken hyperlink in docs/rest-api.md by removing the ../ prefix from the path to the generated Scalar API reference page. The scripts/export_openapi.py script writes its output to docs/_generated/api-reference.html, which is inside the MkDocs docs/ root. Because rest-api.md sits at the top level of the docs tree, the correct relative path is _generated/api-reference.html — not ../_generated/api-reference.html, which escaped the docs directory and caused MkDocs --strict to abort.

  • Root cause confirmed: scripts/export_openapi.py sets OUTPUT_DIR = REPO_ROOT / "docs" / "_generated", placing the file at docs/_generated/api-reference.html — inside the MkDocs source tree.
  • Impact of the bug: The ../ prefix resolved to the repository root (outside docs/), triggering a MkDocs warning that failed both the GitHub Pages and PR Preview CI workflows when run with --strict.
  • Fix: The one-character path correction (../_generated/_generated/) is minimal and precisely targeted.

Confidence Score: 5/5

  • This PR is safe to merge — it is a single, verified path correction with no functional logic changes.
  • The change is a one-line documentation fix. Cross-referencing scripts/export_openapi.py confirms the generated file lives at docs/_generated/api-reference.html, exactly matching the corrected link. No logic, no dependencies, and no risk of regression.
  • No files require special attention.

Important Files Changed

Filename Overview
docs/rest-api.md Removes the erroneous ../ prefix from the API reference link, correcting the path to _generated/api-reference.html which matches the actual output location inside docs/_generated/ as written by scripts/export_openapi.py.

Sequence Diagram

sequenceDiagram
    participant CI as CI Workflow
    participant Script as scripts/export_openapi.py
    participant DocsDir as docs/_generated/
    participant MkDocs as mkdocs build --strict
    participant Site as _site/docs/

    CI->>Script: uv run python scripts/export_openapi.py
    Script->>DocsDir: writes api-reference.html
    Script->>DocsDir: writes openapi.json
    CI->>MkDocs: uv run mkdocs build --strict
    MkDocs->>DocsDir: resolves _generated/api-reference.html ✅
    Note over MkDocs,DocsDir: Previously: ../_generated/ escaped docs/ root → warning/abort
    MkDocs->>Site: copies _generated/api-reference.html to output
Loading

Last reviewed commit: 3827707

@Aureliolo Aureliolo merged commit 3d08f92 into main Mar 12, 2026
17 checks passed
@Aureliolo Aureliolo deleted the fix/mkdocs-api-reference-link branch March 12, 2026 11:19
@Aureliolo Aureliolo temporarily deployed to cloudflare-preview March 12, 2026 11:19 — with GitHub Actions Inactive
Aureliolo added a commit that referenced this pull request Mar 12, 2026
🤖 I have created a release *beep* *boop*
---


##
[0.1.2](v0.1.1...v0.1.2)
(2026-03-12)


### Features

* add /review-dep-pr skill for dependency update PR review
([#315](#315))
([56f6565](56f6565))
* add static OpenAPI reference page with Scalar UI
([#319](#319))
([77cdbcc](77cdbcc))


### Bug Fixes

* correct API reference link path in rest-api.md
([#320](#320))
([3d08f92](3d08f92))


### CI/CD

* bump actions/setup-node from 4.4.0 to 6.3.0
([#311](#311))
([3c99d6f](3c99d6f))
* bump actions/setup-python from 5.6.0 to 6.2.0
([#312](#312))
([3273553](3273553))
* bump astral-sh/setup-uv from 6.0.1 to 7.4.0
([#310](#310))
([b63cee7](b63cee7))


### Maintenance

* bump mkdocstrings[python] from 0.29.1 to 1.0.3
([#314](#314))
([d46ccad](d46ccad))
* bump the minor-and-patch group with 2 updates
([#313](#313))
([6337ae4](6337ae4))
* improve review-dep-pr skill and add Codecov Test Analytics
([#317](#317))
([eb5782e](eb5782e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant