fix: reject empty InteractionFeedback payloads (CodeRabbit round 3)

Aureliolo · Aureliolo · commit fcff01f00929 · 2026-04-03T09:15:46.000+02:00
Add model_validator requiring at least one rating or non-blank free_text
in InteractionFeedback. Prevents empty feedback records with no signal
from being stored. Add tests for empty feedback rejection and
free-text-only feedback acceptance.
diff --git a/src/synthorg/hr/evaluation/models.py b/src/synthorg/hr/evaluation/models.py
@@ -137,6 +137,25 @@ class InteractionFeedback(BaseModel):
         description='Origin of the feedback (e.g. "human", "automated")',
     )
 
+    @model_validator(mode="after")
+    def _validate_has_signal(self) -> Self:
+        """Ensure at least one rating or non-blank free_text is present."""
+        has_rating = any(
+            v is not None
+            for v in (
+                self.clarity_rating,
+                self.tone_rating,
+                self.helpfulness_rating,
+                self.trust_rating,
+                self.satisfaction_rating,
+            )
+        )
+        has_text = self.free_text is not None and self.free_text.strip()
+        if not has_rating and not has_text:
+            msg = "Feedback must contain at least one rating or non-blank free_text"
+            raise ValueError(msg)
+        return self
+
 
 class ResilienceMetrics(BaseModel):
     """Derived resilience metrics from task execution records.
diff --git a/tests/unit/hr/evaluation/test_models.py b/tests/unit/hr/evaluation/test_models.py
@@ -107,10 +107,11 @@ def test_frozen(self) -> None:
         fb = InteractionFeedback(
             agent_id=NotBlankStr("agent-001"),
             recorded_at=datetime.now(UTC),
+            clarity_rating=0.5,
             source=NotBlankStr("human"),
         )
         with pytest.raises(ValidationError):
-            fb.clarity_rating = 0.5  # type: ignore[misc]
+            fb.clarity_rating = 0.9  # type: ignore[misc]
 
     @pytest.mark.parametrize(
         "field",
@@ -165,15 +166,36 @@ def test_auto_generates_id(self) -> None:
         fb1 = InteractionFeedback(
             agent_id=NotBlankStr("agent-001"),
             recorded_at=datetime.now(UTC),
+            clarity_rating=0.5,
             source=NotBlankStr("human"),
         )
         fb2 = InteractionFeedback(
             agent_id=NotBlankStr("agent-001"),
             recorded_at=datetime.now(UTC),
+            clarity_rating=0.5,
             source=NotBlankStr("human"),
         )
         assert fb1.id != fb2.id
 
+    def test_empty_feedback_raises(self) -> None:
+        """Feedback with no ratings and no free_text must raise."""
+        with pytest.raises(ValueError, match="at least one rating"):
+            InteractionFeedback(
+                agent_id=NotBlankStr("agent-001"),
+                recorded_at=datetime.now(UTC),
+                source=NotBlankStr("human"),
+            )
+
+    def test_free_text_only_feedback_ok(self) -> None:
+        """Feedback with only free_text (no ratings) is valid."""
+        fb = InteractionFeedback(
+            agent_id=NotBlankStr("agent-001"),
+            recorded_at=datetime.now(UTC),
+            source=NotBlankStr("human"),
+            free_text="Great job!",
+        )
+        assert fb.free_text == "Great job!"
+
 
 # ── ResilienceMetrics ─────────────────────────────────────
 
