fix: wrap ConfigResolver reads in try/except for graceful fallback

Aureliolo · Aureliolo · commit e09ccda3cd2f · 2026-04-04T10:42:41.000+02:00
ConfigResolver.get_bool/get_int raise SettingNotFoundError if keys
are absent. Wrap both calls so _prepare_context falls back to
defaults (trimming_enabled=True, tokens_override=None) instead of
crashing the agent run.
diff --git a/src/synthorg/engine/agent_engine.py b/src/synthorg/engine/agent_engine.py
@@ -865,16 +865,23 @@ async def _prepare_context(  # noqa: PLR0913
         trimming_enabled = True
         tokens_override: int | None = None
         if self._config_resolver is not None:
-            trimming_enabled = await self._config_resolver.get_bool(
-                "engine",
-                "personality_trimming_enabled",
-            )
-            raw_override = await self._config_resolver.get_int(
-                "engine",
-                "personality_max_tokens_override",
-            )
-            if raw_override > 0:
-                tokens_override = raw_override
+            try:
+                trimming_enabled = await self._config_resolver.get_bool(
+                    "engine",
+                    "personality_trimming_enabled",
+                )
+                raw_override = await self._config_resolver.get_int(
+                    "engine",
+                    "personality_max_tokens_override",
+                )
+                if raw_override > 0:
+                    tokens_override = raw_override
+            except Exception:
+                logger.warning(
+                    PROMPT_PERSONALITY_TRIMMED,
+                    msg="failed to read ENGINE settings, using defaults",
+                    exc_info=True,
+                )
         system_prompt = build_system_prompt(
             agent=identity,
             task=task,
