fix: correct contains() cast, toolbar autodocs, and unhandled WS promise

Aureliolo · claude · Aureliolo · commit 683d4e95fbc1 · 2026-03-27T14:10:04.000+01:00
- NodeContextMenu: cast e.target as Node (not HTMLElement) for contains()
- OrgChartToolbar.stories: set component to OrgChartToolbar so autodocs
  reflect the real props, use render for interactive wrapper
- company store: catch fetchCompanyData promise in WS handler to prevent
  unhandled rejection

Co-Authored-By: Claude Opus 4.6 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/web/src/pages/org/NodeContextMenu.tsx b/web/src/pages/org/NodeContextMenu.tsx
@@ -45,7 +45,7 @@ export function NodeContextMenu({
   // Close on outside click or Escape
   useEffect(() => {
     function handleClick(e: MouseEvent) {
-      if (menuRef.current && !menuRef.current.contains(e.target as HTMLElement)) {
+      if (menuRef.current && !menuRef.current.contains(e.target as Node)) {
         onClose()
       }
     }
diff --git a/web/src/pages/org/OrgChartToolbar.stories.tsx b/web/src/pages/org/OrgChartToolbar.stories.tsx
@@ -17,14 +17,23 @@ function InteractiveToolbar() {
 
 const meta = {
   title: 'OrgChart/OrgChartToolbar',
-  component: InteractiveToolbar,
+  component: OrgChartToolbar,
   tags: ['autodocs'],
   parameters: {
     a11y: { test: 'error' },
   },
-} satisfies Meta<typeof InteractiveToolbar>
+  render: () => <InteractiveToolbar />,
+} satisfies Meta<typeof OrgChartToolbar>
 
 export default meta
 type Story = StoryObj<typeof meta>
 
-export const Default: Story = {}
+export const Default: Story = {
+  args: {
+    viewMode: 'hierarchy',
+    onViewModeChange: () => {},
+    onFitView: () => {},
+    onZoomIn: () => {},
+    onZoomOut: () => {},
+  },
+}
diff --git a/web/src/stores/company.ts b/web/src/stores/company.ts
@@ -50,7 +50,9 @@ export const useCompanyStore = create<CompanyState>()((set) => ({
     // Handle agent lifecycle events that affect company structure
     if (event.event_type === 'agent.hired' || event.event_type === 'agent.fired') {
       // Re-fetch company config to get updated agent list
-      useCompanyStore.getState().fetchCompanyData()
+      useCompanyStore.getState().fetchCompanyData().catch(() => {
+        // Error is already set in store state by fetchCompanyData
+      })
     }
   },
 }))

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ export function NodeContextMenu({`
`45`	`45`	`// Close on outside click or Escape`
`46`	`46`	`useEffect(() => {`
`47`	`47`	`function handleClick(e: MouseEvent) {`
`48`		`- if (menuRef.current && !menuRef.current.contains(e.target as HTMLElement)) {`
	`48`	`+ if (menuRef.current && !menuRef.current.contains(e.target as Node)) {`
`49`	`49`	`onClose()`
`50`	`50`	`}`
`51`	`51`	`}`