fix: pre-push hook fixes + UNC path safety + empty data_dir fallback

Aureliolo · Aureliolo · commit 15df87c0b35b · 2026-03-14T20:46:10.000+01:00
- Remove -race from go-test pre-push hook (requires CGO, unavailable
  on Windows; CI runs -race on Linux)
- Add go-vet to pre-commit.ci skip list
- uninstall.go: reject UNC share roots in deletion safety check
- state.go: fall back to safeDir when config has empty data_dir
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -2,7 +2,7 @@ ci:
   autoupdate_schedule: never
   autofix_prs: true
   autofix_commit_msg: "style: auto-fix pre-commit hooks"
-  skip: [commitizen, gitleaks, hadolint-docker, mypy, pytest-unit, golangci-lint, go-test]
+  skip: [commitizen, gitleaks, hadolint-docker, mypy, pytest-unit, golangci-lint, go-vet, go-test]
 
 default_install_hook_types: [pre-commit, commit-msg, pre-push]
 
@@ -53,14 +53,14 @@ repos:
     hooks:
       - id: mypy
         name: mypy type-check
-        entry: uv run mypy src/ tests/
+        entry: uv run python -m mypy src/ tests/
         language: system
         pass_filenames: false
         stages: [pre-push]
 
       - id: pytest-unit
         name: pytest unit tests
-        entry: uv run pytest tests/ -m unit -n auto -q
+        entry: uv run python -m pytest tests/ -m unit -n auto -q
         language: system
         pass_filenames: false
         stages: [pre-push]
@@ -83,7 +83,7 @@ repos:
 
       - id: go-test
         name: go test (CLI)
-        entry: bash -c 'cd cli && go test -race ./...'
+        entry: bash -c 'cd cli && go test ./...'
         language: system
         files: ^cli/.*\.go$
         pass_filenames: false
diff --git a/cli/cmd/uninstall.go b/cli/cmd/uninstall.go
@@ -4,6 +4,7 @@ import (
 	"fmt"
 	"os"
 	"path/filepath"
+	"strings"
 
 	"github.com/Aureliolo/synthorg/cli/internal/config"
 	"github.com/Aureliolo/synthorg/cli/internal/docker"
@@ -111,10 +112,13 @@ func confirmAndRemoveData(cmd *cobra.Command, dataDir string) error {
 	}
 
 	if removeData {
-		dir := dataDir
-		// Safety: refuse to remove root, home, or empty paths.
+		dir := filepath.Clean(dataDir)
+		// Safety: refuse to remove root, home, UNC share roots, or drive roots.
 		home, _ := os.UserHomeDir()
-		if dir == "/" || dir == home || (len(dir) == 3 && dir[1] == ':' && dir[2] == '\\') {
+		vol := filepath.VolumeName(dir)
+		isUNC := strings.HasPrefix(vol, `\\`) || strings.HasPrefix(vol, "//")
+		isDriveRoot := len(dir) == 3 && dir[1] == ':' && (dir[2] == '\\' || dir[2] == '/')
+		if dir == "/" || dir == home || isDriveRoot || isUNC {
 			return fmt.Errorf("refusing to remove %q — does not look like an app data directory", dir)
 		}
 		if err := os.RemoveAll(dir); err != nil {
