Skip to content

Fix #146: Improve grouping of whole note heads into chords#898

Merged
hbitteur merged 1 commit intoAudiveris:masterfrom
drtootsie:fix-146
Mar 7, 2026
Merged

Fix #146: Improve grouping of whole note heads into chords#898
hbitteur merged 1 commit intoAudiveris:masterfrom
drtootsie:fix-146

Conversation

@drtootsie
Copy link
Copy Markdown
Contributor

Improved grouping of whole note heads into chords by increasing vertical pitch tolerance and refining horizontal overlap detection. This addresses the issue where vertically aligned semibreves were being split into multiple chords.

@hbitteur hbitteur merged commit 22a8d0d into Audiveris:master Mar 7, 2026
@hbitteur
Copy link
Copy Markdown
Contributor

hbitteur commented Mar 7, 2026

@drtootsie
I merged all your PRs into master branch, I will forward them to the development branch anytime soon.

I have a question about this PR on whole note head chords.
You define a "xTolerance" variable as:

final double xTolerance = scale.getInterline().doubleValue() / 2.0;

What is the reason for using precisely half the interline value?
I'm wondering if we should use an application constant instead of a hard-coded value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants