Skip to content

MusicXML: no export for repeat sign + shifted notes #118

New issue
New issue
Closed
Closed
MusicXML: no export for repeat sign + shifted notes#118
Labels
bug
@maximumspatium

Description

@maximumspatium
maximumspatium
opened on Mar 10, 2018

This score exposes two bugs in the integrated MusicXML exporter:

  1. shifted notes
  2. missing repeat sign

The pictures below visualize these issues:

over correct
over wrong musicxml

To reproduce the first case, do the following steps:

  • open the image
  • transcribe it
  • export the sheet as MusicXML
  • import it in MuseScore. Measure 7 should have shifted notes as shown in the 2nd picture above.
  • save the book
  • close the book
  • reopen the book
  • export the sheet again

Importing it again in MuseScore after saving will magically correct the notes. So it looks like something is left in an inconsistent state during recognition. Saving seems to auto-fix it somehow.

UPDATE: it looks like an invalid clef (TREBLE_CLEF) will be reported for the measure 7...

Regarding the 2nd case, repeat export will be prevented by this check:

audiveris/src/main/org/audiveris/omr/score/PartwiseBuilder.java

Lines 920 to 927 in 3d8ede5

if ((partBarline == current.measure.getLeftBarline())
|| (location == RightLeftMiddle.MIDDLE)
|| ((location == RightLeftMiddle.RIGHT)
&& (stack.isRepeat(RIGHT) || !fermatas.isEmpty() || (ending != null)
|| (style != PartBarline.Style.REGULAR)))
|| ((location == RightLeftMiddle.LEFT) && (stack.isRepeat(LEFT) || (ending != null)))) {
try {
logger.debug("Visiting {} on {}", partBarline, location);

I have no clue why it doesn't work. This compound if-statement is almost ungrokable to me. It cries out for refactoring!

Metadata

Metadata

Assignees

No one assigned

    Labels

    bug

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions