Skip to content

Can't disable min_java version validation #3

@ykrasik

Description

@ykrasik

Hi,

Thanks for this library.

I ran into an issue when bundling a Java app using JavaPackager.
In my Gradle script I'm specifying the JavaPackager.jrePath as jrePath = new File(System.properties['java.home']). I'm bundling the app with the JRE that comes with the JDK. However, the release file of my JDK (1.8) is not located inside the jre folder which gets bundled, but it sits as a child of the jdk folder - see below.

jdk1.8.0_271
|-> release
|-> jre    <- this is what gets bundled
    |-> no release file

This causes the bundled jre to be considered incompatible by this code.

Currently, there is no way to completely disable this version validation, as even setting the min_java to 0 or leaving it unset causes the validation to run (and fail). For the case of bundling a JRE, this validation should be turned off.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions