fix: drop Traditional Chinese locale support by Astro-Han · Pull Request #99 · Astro-Han/pawwork

Astro-Han · 2026-04-21T13:10:53Z

Summary

Remove Traditional Chinese as a PawWork product-supported locale. PawWork now exposes only English and Simplified Chinese in app and Electron locale surfaces, while legacy Traditional Chinese values and Traditional Chinese language tags fall back to Simplified Chinese.

Why

Traditional Chinese is a separate language support commitment, and PawWork's current product goal is to maintain only English and Simplified Chinese. This keeps localization scope smaller while preserving a reasonable fallback for existing zht users and zh-Hant / zh-TW / zh-HK / zh-MO environments.

Related Issue

None.

How To Verify

bun --cwd packages/app test:unit
bun --cwd packages/desktop-electron test
bun --cwd packages/app typecheck
bun --cwd packages/desktop-electron typecheck
rg -n "zht|zh-Hant|language\.zht|isTraditionalChinese" packages/app/src packages/desktop-electron/src
rg --files packages/app/src packages/desktop-electron/src | rg '/zht\.ts$'

The final rg content check is expected to find only compatibility code and tests for legacy zht / zh-Hant; the product zht.ts file check should return no app or desktop files.

Screenshots or Recordings

Not included. This is a locale support scope change covered by unit tests and typechecks.

Checklist

I ran the relevant verification steps
I tested visible changes manually when needed
I am targeting the dev branch

Summary by CodeRabbit

Chores
- Removed the separate Traditional Chinese ("zht") locale; language selection and resources now use "zh" only.
Bug Fixes
- Improved locale normalization: legacy/variant inputs (including mixed-case or underscore forms) now map consistently to "zh", unsupported or non-string values default to "en", and uppercase "EN" is recognized as "en".

coderabbitai · 2026-04-21T13:11:14Z

📝 Walkthrough

Walkthrough

This PR removes the separate Traditional Chinese ("zht") locale and related detectors, collapses all zh-* inputs to the single zh locale (with non-string inputs falling back to en), and deletes the zht i18n dictionaries and tests that referenced zht.

Changes

Cohort / File(s)	Summary
Language context `packages/app/src/context/language.tsx`, `packages/app/src/context/language.test.ts`	Removed `"zht"` from `Locale` and loaders, deleted `isTraditionalChinese`, changed `normalizeLocale(value: unknown): Locale` to normalize any `zh*` (case-insensitive) to `"zh"` and return `"en"` for non-strings; updated tests to assert `normalizeLocale` behavior.
App i18n dictionaries `packages/app/src/i18n/en.ts`, `packages/app/src/i18n/zh.ts`, `packages/app/src/i18n/zht.ts`	Deleted `zht.ts` module; removed `language.zht` keys from `en` and `zh` dictionaries.
App i18n parity test `packages/app/src/i18n/parity.test.ts`	Removed `zht` import and references so parity checks run only against remaining locales (e.g., `zh`, `en`).
Desktop renderer i18n core `packages/desktop-electron/src/renderer/i18n/index.ts`, `packages/desktop-electron/src/renderer/i18n/index.test.ts`	Removed `zht` imports and `isTraditionalChinese` logic; narrowed `Locale` to `"en"
Desktop renderer zht dictionary `packages/desktop-electron/src/renderer/i18n/zht.ts`	Deleted `zht` i18n dictionary (Traditional Chinese strings for desktop UI).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Possibly related PRs

fix: polish review git changes UI #90 — touches the same locale/i18n surface: adds/uses zht entries and UI behavior that may conflict with removal of the zht locale.

Poem

🐰 Hopping through code with a joyful squeak,
Zht folds its map and hops off the peak.
One zh to guide the language trail,
Simpler carrots on a single trail,
Thump-thump — rabbit says: neat! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'fix: drop Traditional Chinese locale support' directly and clearly summarizes the main change of removing Traditional Chinese (zht) as a supported locale across the codebase.
Description check	✅ Passed	The description covers all template sections: Summary explains the locale removal, Why provides rationale, Related Issue is addressed, How To Verify includes comprehensive test/typecheck commands and grep verification, and Checklist items are appropriately marked (verification and dev branch targeting confirmed).
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch codex/fix-drop-zht-locale

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

gemini-code-assist

Code Review

This pull request removes Traditional Chinese (zht) as a distinct locale, consolidating all Chinese language variants into Simplified Chinese (zh). The changes involve deleting translation files, updating locale type definitions, and refactoring detection and normalization logic across both the web and desktop applications. Review feedback identified redundant checks and potential case-sensitivity bugs in the updated normalizeLocale and parseLocale functions, where uppercase locale strings might fail to match supported values.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fa90c59636

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Astro-Han · 2026-04-21T13:33:06Z

@coderabbitai review

coderabbitai · 2026-04-21T13:36:37Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@packages/desktop-electron/src/renderer/i18n/index.ts`:
- Around line 30-35: The parseLocale implementation duplicates logic in
normalizeLocale—extract a single shared normalization helper (e.g., export
function normalizeLocaleShared) into a common/shared module and have both
parseLocale and the existing normalizeLocale import and delegate to that helper;
ensure the shared helper keeps the same behavior (string check, toLowerCase, zh
prefix -> "zh", membership check against LOCALES), export the Locale type or
reuse the existing type so parseLocale (and normalizeLocale in packages/app)
return the same Locale | null shape, and update imports in parseLocale and
normalizeLocale to reference the new shared function.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: e0e69682-e1d3-4172-8402-e88b73e710f9

📥 Commits

Reviewing files that changed from the base of the PR and between fa90c59 and 22dfeaf.

📒 Files selected for processing (4)

packages/app/src/context/language.test.ts
packages/app/src/context/language.tsx
packages/desktop-electron/src/renderer/i18n/index.test.ts
packages/desktop-electron/src/renderer/i18n/index.ts

fix: drop Traditional Chinese locale support

fa90c59

Astro-Han added enhancement New feature or request P2 Medium priority app Application behavior and product flows platform Electron shell, OS integration, packaging, updater, signing, paths, and permissions labels Apr 21, 2026

gemini-code-assist Bot reviewed Apr 21, 2026

View reviewed changes

Comment thread packages/app/src/context/language.tsx Outdated

Comment thread packages/desktop-electron/src/renderer/i18n/index.ts

chatgpt-codex-connector Bot reviewed Apr 21, 2026

View reviewed changes

Comment thread packages/app/src/context/language.tsx

fix: harden locale normalization

22dfeaf

coderabbitai Bot reviewed Apr 21, 2026

View reviewed changes

Comment thread packages/desktop-electron/src/renderer/i18n/index.ts

Astro-Han merged commit 6296764 into dev Apr 21, 2026
16 checks passed

Astro-Han deleted the codex/fix-drop-zht-locale branch April 21, 2026 13:46

coderabbitai Bot mentioned this pull request Apr 21, 2026

fix: improve desktop menu updates and feedback #98

Closed

7 tasks

Astro-Han mentioned this pull request Apr 22, 2026

[Bug] Update notice shows raw release download link #124

Closed

coderabbitai Bot mentioned this pull request Apr 22, 2026

fix: isolate PawWork runtime storage #126

Merged

7 tasks

coderabbitai Bot mentioned this pull request Apr 30, 2026

fix: default review to last turn #338

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: drop Traditional Chinese locale support#99

fix: drop Traditional Chinese locale support#99
Astro-Han merged 2 commits into
devfrom
codex/fix-drop-zht-locale

Astro-Han commented Apr 21, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Apr 21, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

❌ Failed checks (1 warning)

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

Astro-Han commented Apr 21, 2026

Uh oh!

coderabbitai Bot commented Apr 21, 2026

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

Astro-Han commented Apr 21, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Why

Related Issue

How To Verify

Screenshots or Recordings

Checklist

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Apr 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Poem

❌ Failed checks (1 warning)

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Astro-Han commented Apr 21, 2026

Uh oh!

coderabbitai Bot commented Apr 21, 2026

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Astro-Han commented Apr 21, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Apr 21, 2026 •

edited

Loading